Update patch set 21

Patch Set 21:

(1 comment)

> I think the way we should deploy this is disable the puppet cron,
 > merge this change, then use our adhoc script to test this against
 > one of our simpler deployments (note we may have to run the adhoc
 > script multiple times the first time will update the ansible role
 > but use the old version? then second time use the new version?)

Sounds like a good plan. I didn't think about how the role gets updated - it looks like it's part of the update_puppet.yaml playbook, which is part of the run_all.sh script but not part of the adhoc playbook. So if we want to do it one at a time we might have to update the role manually?

Patch-set: 21
Reviewer: Gerrit User 8482 <8482@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0

4d64868882038dd846e5128d70d3eaccf2d0ec59

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9f6a8fd7_fb3395a9",
+        "filename": "defaults/main.yml",
+        "patchSetId": 21
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 8482
+      },
+      "writtenOn": "2018-04-24T18:21:13Z",
+      "side": 1,
+      "message": "To clarify this - the default if this is not specified is \u0027/etc/puppet/modules:/usr/share/puppet/modules\u0027 on puppet 3 (/etc/puppet \u003d\u003d $confdir) and \u0027/etc/puppetlabs/code/modules:/opt/puppetlabs/puppet/modules\u0027 on puppet 4. So this should be backwards compatible for people who have modules installed at /etc/puppet/modules with puppet 3. If they\u0027re upgrading to puppet 4 (like we are) they/we will have to either move the modules or set this explicitly.",
+      "revId": "4d64868882038dd846e5128d70d3eaccf2d0ec59",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}