Merge "Enable pylint"

.pylintrc

@@ -0,0 +1,50 @@
+[MASTER]
+jobs = 0
+
+[MESSAGES CONTROL]
+
+disable =
+    # TODO(ssbarnea): remove temporary skips adding during initial adoption:
+    broad-except,
+    dangerous-default-value,
+    duplicate-code,
+    fixme,
+    function-redefined,
+    global-statement,
+    import-error,
+    import-outside-toplevel,
+    inconsistent-return-statements,
+    invalid-name,
+    line-too-long,
+    literal-comparison,
+    logging-not-lazy,
+    missing-class-docstring,
+    missing-function-docstring,
+    missing-module-docstring,
+    no-else-break,
+    no-else-raise,
+    no-else-return,
+    no-member,
+    no-self-use,
+    protected-access,
+    redefined-outer-name,
+    simplifiable-if-expression,
+    super-init-not-called,
+    super-with-arguments,
+    too-few-public-methods,
+    too-many-arguments,
+    too-many-branches,
+    too-many-instance-attributes,
+    too-many-locals,
+    too-many-statements,
+    undefined-loop-variable,
+    ungrouped-imports,
+    unidiomatic-typecheck,
+    unused-argument,
+    unused-variable,
+    useless-else-on-loop,
+    useless-object-inheritance,
+    wrong-import-order,
+
+[REPORTS]
+output-format=colorized

test-requirements.txt

@@ -1,4 +1,3 @@
-hacking>=3.1.0,<3.2.0; python_version>='3.5'
 coverage>=3.6
 fixtures>=3.0.0
 python-subunit

tox.ini

@@ -53,5 +53,9 @@ commands = bindep test
 
 [testenv:linters]
 basepython = python3
-commands = flake8
-
+deps =
+   flake8==3.8.3
+   pylint==2.6.0
+commands =
+   flake8
+   pylint elastic_recheck