opendev
/
elastic-recheck
Code Issues Proposed changes

Fix MessageConfig 

MessageConfig is a dictionary, but __init__ was updating __dict__ and
not self.  This bug was causing elastic-recheck to stacktrace when it
tries to comment on a gerrit patch.

Change-Id: Ic4304336692226acfe60d0845edaf2acb383acc6
This commit is contained in:
Joe Gordon 2014-08-12 12:15:18 -07:00
parent 40346c1d98
commit e9c4450cf8
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
elastic_recheck/bot.py
View File

@ -218,7 +218,8 @@ class RecheckWatch(threading.Thread):
class MessageConfig(dict):
def __init__(self, data):
self.__dict__.update(data['messages'])
super(MessageConfig, self).__init__()
self.update(data['messages'])
class ChannelConfig(object):

5
elastic_recheck/tests/unit/test_bot.py
View File

@ -135,3 +135,8 @@ class TestBotWithTestTools(tests.TestCase):
job.bugs = ['123456']
self.assertTrue(self.recheck_watch.display('channel', event))
self.recheck_watch.error_found('channel', event)
def test_message_config(self):
data = {'messages': {'test': 'message'}}
config = bot.MessageConfig(data)
self.assertEqual(config['test'], data['messages']['test'])