pylint: fixed imports

Fixed pylint violations around imports. Implements
standard import ordering (isort).

Change-Id: Ib89108925487e49109d18ae315cd4892b8b48837

.pylintrc

@@ -11,8 +11,6 @@ disable =
     fixme,
     function-redefined,
     global-statement,
-    import-error,
-    import-outside-toplevel,
     inconsistent-return-statements,
     invalid-name,
     line-too-long,
@@ -41,7 +39,6 @@ disable =
     unused-variable,
     useless-else-on-loop,
     useless-object-inheritance,
-    wrong-import-order,
 
 [REPORTS]
 output-format=colorized

elastic_recheck/bot.py

@@ -43,13 +43,13 @@ openstack-qa:
 ```
 """
 import argparse
-import daemon
 import os
 import textwrap
 import threading
 import time
-import yaml
 
+import daemon
+import yaml
 import irc.bot
 from launchpadlib import launchpad
 
@@ -201,6 +201,7 @@ class RecheckWatch(threading.Thread):
 
     def run(self):
         # Import here because it needs to happen after daemonization
+        # pylint: disable=import-outside-toplevel
         import elastic_recheck.elasticRecheck as er
         classifier = er.Classifier(self.queries, config=self.config)
         stream = er.Stream(self.username, self.host, self.key,

elastic_recheck/elasticRecheck.py

@@ -12,6 +12,11 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+import datetime
+import logging
+import re
+import time
+
 import dateutil.parser as dp
 import gerritlib.gerrit
 import pyelasticsearch
@@ -19,11 +24,6 @@ import sqlalchemy
 from sqlalchemy import orm
 from subunit2sql.db import api as db_api
 
-import datetime
-import logging
-import re
-import time
-
 import elastic_recheck.config as er_conf
 import elastic_recheck.loader as loader
 import elastic_recheck.query_builder as qb

elastic_recheck/tests/functional/test_gerrit_comment.py

@@ -12,8 +12,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-import gerritlib
 import configparser
+
+import gerritlib
 import testtools
 
 from elastic_recheck import elasticRecheck

elastic_recheck/tests/functional/test_queries.py

@@ -12,9 +12,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 from functools import lru_cache
+import logging
 import os
 import pytest
-import logging
 
 from launchpadlib import launchpad
 

elastic_recheck/tests/unit/__init__.py

@@ -9,9 +9,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+import json
 
 import fixtures
-import json
 
 from elastic_recheck import loader
 import elastic_recheck.tests

tox.ini

@@ -57,6 +57,7 @@ basepython = python3
 deps =
    flake8==3.8.3
    pylint==2.6.0
+   -r{toxinidir}/test-requirements.txt
 commands =
    flake8
    pylint elastic_recheck