opendev
/
gerrit
Code Issues Proposed changes

Merge branch 'stable-2.15' 

* stable-2.15:
  PolyGerrit: Update documentation
  Support for GWT to PolyGerrit integration plugin migration
  Update the plugin development documentation.
  Update PolyGerrit plugin documentation

Change-Id: I6b80221d85d3c045f935e8d2accfc23519293c70
This commit is contained in:
Paladox 2018-01-25 01:41:55 +00:00 committed by Paladox none
parent 3d8223a3cd feeee82bd5
commit 1f7c13f3a5
1 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
Documentation/pg-plugin-migration.txt
View File

@ -7,18 +7,17 @@ feedback] if something's not right.
[[migration]]
== Incremental migration of existing GWT UI plugins
link:pg-plugin-dev.html[PolyGerrit plugin API] operates different concepts and
provides different type of API compared to ones available to GWT
link:pg-plugin-dev.html[PolyGerrit plugin API] is based on different concepts and
provides a different type of API compared to the one available to GWT
plugins. Depending on the plugin, it might require significant modifications to
existing UI scripts to fully take advantage of benefits PolyGerrit API
provides.
existing UI scripts to fully take advantage of the benefits provided by the PolyGerrit API.
To make migration easier, PolyGerrit recommends incremental migration
To make migration easier, PolyGerrit recommends an incremental migration
strategy. Starting with a .js file that works for GWT UI, plugin author can
incrementally migrate deprecated APIs to new plugin API.
incrementally migrate deprecated APIs to the new plugin API.
The goal for this guide is to provide migration path from .js-based UI script to
.html-based.
The goal for this guide is to provide a migration path from .js-based UI script to
a html based implementation
NOTE: Web UI plugins distributed as a single .js file are not covered in this
guide.
@ -54,10 +53,10 @@ public class SamplePluginModule extends AbstractModule {
=== Step 1: Create `sampleplugin.html`
As a first step, create starter `sampleplugin.html` and include UI script in the
As a first step, create `sampleplugin.html` and include the UI script in the
module file.
NOTE: GWT UI ignore .html since it's not supported.
NOTE: GWT UI ignores html files which it doesn't support.
``` java
@Override
@ -108,20 +107,20 @@ callbacks
- `plugin.deprecated.install()` enables deprecated APIs (onAction(), popup(),
etc) before `sampleplugin.js` is loaded
So the purpose is to share plugin instance between .html-based and .js-based
code, making it possible to gradually and incrementally transfer code to new API.
This means the plugin instance is shared between .html-based and .js-based
code. This allows to gradually and incrementally transfer code to the new API.
=== Step 2: Create cut-off marker in `sampleplugin.js`
Commonly, window.Polymer is being used to detect in GWT UI script if it's being
executed inside PolyGerrit. This could be used to separate code that was already
migrated to new APIs from the one that hasn't been migrated yet.
migrated to new APIs from old not yet migrated code.
During incremental migration, some of the UI code will be reimplemented using
PolyGerrit plugin API. However, old code still could be required for the plugin
the PolyGerrit plugin API. However, old code still could be required for the plugin
to work in GWT UI.
To handle this case, add following code to be the last thing in installation
To handle this case, add the following code at the end of the installation
callback in `sampleplugin.js`
``` js
@ -143,11 +142,11 @@ non-deprecated counterparts. Duplicated pieces could be kept under cut-off
marker to work in GWT UI.
If some data or functions needs to be shared between code in .html and .js, it
could be stored on `plugin` (aka `self`) object that's shared between both
could be stored in the `plugin` (aka `self`) object that's shared between both
=== Step 4: Cleanup
Once deprecated APIs are migrated, `sampleplugin.js` will only contain
duplicated code that's required for GWT UI to work. With sudden but inevitable
GWT code removal from Gerrit that file can be simply deleted, along with script
tag loading it.
duplicated code that's required for GWT UI to work. As soon as GWT support is removed from Gerrit
that file can be simply deleted, along with the script tag loading it.