opendev
/
gerrit
Code Issues Proposed changes

Make the line length indicator color clearer 

Issue: Bug 13648
Change-Id: I523d971f39db477d67e212d1175ec6f5be8be24d
(cherry picked from commit 595d19b40bd1ff1ef8930762b7cd9cbc64da90cb)
This commit is contained in:
Dhruv Srivastava 2021-04-06 13:50:58 +02:00 committed by Paladox none
parent 31f3904d3c
commit 4022926893
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/diff/gr-diff/gr-diff_html.ts
View File

@ -511,8 +511,7 @@ export const htmlTemplate = html`
}
/** Support the line length indicator **/
.full-width td.content .contentText {
/* Base 64 encoded 1x1px of #ddd */
background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO8+x8AAr8B3gzOjaQAAAAASUVORK5CYII=');
background-image: var(--line-length-indicator);
background-position: var(--line-limit) 0;
background-repeat: repeat-y;
}

2
polygerrit-ui/app/styles/themes/app-theme.ts
View File

@ -375,6 +375,8 @@ const styleSheet = safeStyleSheet`
/* misc */
--border-radius: 4px;
--reply-overlay-z-index: 1000;
/* Base 64 encoded 1x1px of #681da8 */
--line-length-indicator: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQYV2PIlF2xAgAD+AHXfBDdKAAAAABJRU5ErkJggg==');
/* paper and iron component overrides */
--iron-overlay-backdrop-background-color: black;

2
polygerrit-ui/app/styles/themes/dark-theme.ts
View File

@ -228,6 +228,8 @@ function getStyleEl() {
--syntax-variable-color: #f77669;
/* misc */
/* Base 64 encoded 1x1px of #d7aefb; */
--line-length-indicator: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQYV2O4vu73fwAIYAOAtqAXCQAAAABJRU5ErkJggg==');
/* paper and iron component overrides */
--iron-overlay-backdrop-background-color: white;