opendev
/
gerrit
Code Issues Proposed changes

Remove experiments for comment context and checks 

Both experiments were successful and should we turned on by default,
both on stable-3.4 and master branch.

Change-Id: I130b7846414e281062906def588151da71d72d96
This commit is contained in:
Ben Rohlfs 2021-04-23 19:39:15 +02:00
parent c08843cc27
commit 61d14debff
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.ts
View File

@ -212,10 +212,6 @@ export class GrCommentThread extends KeyboardShortcutMixin(PolymerElement) {
private readonly syntaxLayer = new GrSyntaxLayer();
private isCommentContextExperimentEnabled = this.flagsService.isEnabled(
KnownExperimentId.COMMENT_CONTEXT
);
readonly restApiService = appContext.restApiService;
constructor() {
@ -261,11 +257,7 @@ export class GrCommentThread extends KeyboardShortcutMixin(PolymerElement) {
}
_shouldShowCommentContext(diff?: DiffInfo) {
return (
this.isCommentContextExperimentEnabled &&
this.showCommentContext &&
!!diff
);
return this.showCommentContext && !!diff;
}
addOrEditDraft(lineNum?: LineNumber, rangeParam?: CommentRange) {

6
polygerrit-ui/app/services/flags/flags.ts
View File

@ -24,10 +24,6 @@ export interface FlagsService {
* @desc Experiment ids used in Gerrit.
*/
export enum KnownExperimentId {
// Note that this flag is not supposed to be used by Gerrit itself, but can
// be used by plugins. The new Checks UI will show up, if a plugin registers
// with the new Checks plugin API.
CI_REBOOT_CHECKS = 'UiFeature__ci_reboot_checks',
NEW_IMAGE_DIFF_UI = 'UiFeature__new_image_diff_ui',
COMMENT_CONTEXT = 'UiFeature__comment_context',
TOKEN_HIGHLIGHTING = 'UiFeature__token_highlighting',
}