opendev
/
gerrit
Code Issues Proposed changes

Make sure that ENTER works in all text fields 

There is a bug in gwt 2.1.0 [1] that prevents that pressing the ENTER
key is properly recognized and so actions that are connected with
pressing ENTER are not triggered.

Examples:
- confirming a query in the query input field with ENTER does not
  trigger the query
- confirming the login information in the UserPassSignInDialog with
  ENTER does not trigger the login
- confirming to add a reviewer in the ChangeScreen with ENTER does
  not add the reviewer

This problem only affects some browsers (e.g. Firefox, older versions
of Google Chrome).

The new code was tested with Google Chrome 11.0.696.68,
Firefox 3.6.17, Firefox 4.0.1 and Internet Explorer 8.0.7600.1685.

[1] http://code.google.com/p/google-web-toolkit/issues/detail?id=5558

Bug: issue 946
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Change-Id: Ia61ba2fbd150e1c587d7c40252d500e28a99711b
This commit is contained in:
Edwin Kempin 2011-05-18 20:21:24 +02:00
parent 0908bff975
commit 676d5b3d73
12 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchPanel.java
View File

@ -46,7 +46,7 @@ class SearchPanel extends Composite {
searchBox.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(final KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doSearch();
}
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyWatchedProjectsScreen.java
View File

@ -173,7 +173,7 @@ public class MyWatchedProjectsScreen extends SettingsScreen implements
public void onKeyPress(KeyPressEvent event) {
submitOnSelection = false;
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
if (nameTxt.isSuggestionListShowing()) {
submitOnSelection = true;
} else {
@ -198,7 +198,7 @@ public class MyWatchedProjectsScreen extends SettingsScreen implements
filterTxt.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doAddNew();
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/UsernameField.java
View File

@ -58,7 +58,7 @@ class UsernameField extends Composite {
userNameTxt.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doSetUserName();
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccessRightEditor.java
View File

@ -108,7 +108,7 @@ public class AccessRightEditor extends Composite
referenceTxt.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doAddNewRight();
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupScreen.java
View File

@ -386,7 +386,7 @@ public class AccountGroupScreen extends AccountScreen {
externalNameFilter.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(final KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doExternalSearch();
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
View File

@ -75,7 +75,7 @@ public class GroupListScreen extends AccountScreen {
addTxt.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doCreateGroup();
}
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java
View File

@ -112,7 +112,7 @@ public class ProjectBranchesScreen extends ProjectScreen {
nameTxtBox.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doAddNewBranch();
}
}
@ -126,7 +126,7 @@ public class ProjectBranchesScreen extends ProjectScreen {
irevTxtBox.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doAddNewBranch();
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/auth/openid/OpenIdSignInDialog.java
View File

@ -181,7 +181,7 @@ public class OpenIdSignInDialog extends SignInDialog implements
providerId.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(final KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
event.preventDefault();
form.submit();
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/auth/userpass/UserPassSignInDialog.java
View File

@ -114,7 +114,7 @@ public class UserPassSignInDialog extends SignInDialog {
username.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(final KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
event.preventDefault();
password.selectAll();
password.setFocus(true);
@ -128,7 +128,7 @@ public class UserPassSignInDialog extends SignInDialog {
password.addKeyPressHandler(new KeyPressHandler() {
@Override
public void onKeyPress(final KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
event.preventDefault();
onLogin();
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java
View File

@ -117,7 +117,7 @@ public class PatchScriptSettingsPanel extends Composite implements
KeyPressHandler onEnter = new KeyPressHandler() {
@Override
public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
update();
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddIncludedGroupBox.java
View File

@ -51,7 +51,7 @@ public class AddIncludedGroupBox extends Composite {
public void onKeyPress(KeyPressEvent event) {
submitOnSelection = false;
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
if (nameTxt.isSuggestionListShowing()) {
submitOnSelection = true;
} else {

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java
View File

@ -52,7 +52,7 @@ public class AddMemberBox extends Composite {
public void onKeyPress(KeyPressEvent event) {
submitOnSelection = false;
if (event.getCharCode() == KeyCodes.KEY_ENTER) {
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
if (nameTxt.isSuggestionListShowing()) {
submitOnSelection = true;
} else {