opendev
/
git-review
Code Issues Proposed changes

tox.ini: add passenv = http_proxy https_proxy # _JAVA_OPTIONS 

Add: 'passenv = http_proxy https_proxy' whitelist to tox.ini because there's
basically never any good reason to throw away proxy configuration.

The addition of http_proxy allows downloading
http://tarballs.openstack.org/ci/gerrit/gerrit-<version>.war
behind a proxy.

https_proxy is not needed right now but added for consistency and
"future-proofing"

_JAVA_OPTIONS is added but only as a clue and commented out by default
because it could hold non-proxy configuration which would defeat tox'
environment cleaning and introduce test variability.

This is just the tox.ini source code part of the larger
I764ed51314c8e2d0572d1f01c9792bee0a40c7e6
includes documentation of workarounds and troubleshooting tips.

Change-Id: I764ed51314c8e2d0572d1f01c9792bee0a40c7e7
This commit is contained in:
Marc Herbert 2018-12-11 13:13:40 -08:00
parent dfb37fa0e0
commit 205859c788
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tox.ini
View File

@ -2,6 +2,11 @@
envlist = pep8,docs,py27,py3{4,5,6,7}
[testenv]
# See "testing behind a proxy"
# @ https://review.openstack.org/#/q/I764ed51314c8e2d0572d1f0
passenv = http_proxy https_proxy
# passenv = http_proxy https_proxy _JAVA_OPTIONS
commands =
python -m git_review.tests.check_test_id_hashes discover --list
python -m git_review.tests.prepare