opendev
/
git-review
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
This commit is contained in:
Gerrit User 4146 2024-03-05 15:27:11 +00:00 committed by Gerrit Code Review
parent 1bde400e42
commit 9402c0e885
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
bfc65a483e8520be9ce1e2e12bcdb869f1140531 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "226892b7_c784efaa",
"filename": "git_review/cmd.py",
"patchSetId": 3
},
"lineNbr": 1785,
"author": {
"id": 4146
},
"writtenOn": "2024-03-05T15:27:11Z",
"side": 1,
"message": "This check implies that if the hook is installed in any valid hook dir then we don\u0027t need to install the hook. Given that why do we need to change git-review to accomodate work trees? Git review should be able to continue to install the hook to more local .git/hooks location and it would work? We may end up installing redundant hooks, but that keeps the git-review hook management a bit simpler.",
"revId": "bfc65a483e8520be9ce1e2e12bcdb869f1140531",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}