opendev
/
git-review
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(1 comment)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 5263 \u003c5263@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
Gerrit User 13252 2024-03-13 12:14:36 +00:00 committed by Gerrit Code Review
parent 3ea99b2631
commit a887325a10
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
43c92f2e7cc8ecad14b2b704adfc3db5cf8cd848
View File

@ -51,6 +51,24 @@
"parentUuid": "cc8c6284_b1752245",
"revId": "43c92f2e7cc8ecad14b2b704adfc3db5cf8cd848",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "47a71fee_c2a207ef",
"filename": "git-review.1",
"patchSetId": 11
},
"lineNbr": 166,
"author": {
"id": 13252
},
"writtenOn": "2024-03-13T12:14:36Z",
"side": 1,
"message": "To me, this is similar to how \"To:\" vs. \"Cc:\" are (or can be) used in mails, \"please handle (review) this\" vs. \"please have a look, this might be interesting for you, but no immediate action required\". Note that submitting a comment via the UI that doesn\u0027t set any vote will also add the submitter to the CC list instead of the reviewers list.\n\nBut maybe I\u0027m also overthinking this, since Gerrit is a code review system, any user will also be a reviewer by definition. So let\u0027s just proceed, or do you want to keep this for the next release?",
"parentUuid": "2f5270ca_41a471e2",
"revId": "43c92f2e7cc8ecad14b2b704adfc3db5cf8cd848",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}