opendev
/
git-review
Code Issues Proposed changes
Tool for uploading changesets to Gerrit from git
488 Commits 1 Branch 41 Tags 7 MiB
Python 89.3%
Roff 10.7%
Go to file
Marc Herbert d41f5d7d0a tests/__init__.py: ssh-keygen -m PEM for bouncycastle 
From: https://www.openssh.com/txt/release-7.8 change log:

 * ssh-keygen(1): write OpenSSH format private keys by default
   instead of using OpenSSL's PEM format. The OpenSSH format,
   supported in OpenSSH releases since 2014 and described in the
   PROTOCOL.key file in the source distribution, offers substantially
   better protection against offline password guessing and supports
   key comments in private keys. If necessary, it is possible to write
   old PEM-style keys by adding "-m PEM" to ssh-keygen's arguments
   when generating or updating a key.

This fixes all tests failing with this error:

[2018-12-04 17:46:24,130] WARN  org.apache.sshd.common.keyprovider.FileKeyPairProvider :
   Unable to read key /home/mherber2/pip/src/git-review/.gerrit/site-5123/etc/ssh_host_rsa_key
java.io.IOException: unrecognised object: OPENSSH PRIVATE KEY
	at org.bouncycastle.openssl.PEMParser.readObject(Unknown Source)
	at org.apache.sshd.common.keyprovider.FileKeyPairProvider.doLoadKey(FileKeyPairProvider.java:124)

Change-Id: Id10f9b5be928f2ba57847fa32814e9db979375f5
 		2018-12-04 18:12:06 -08:00
doc Start using reno for releasenotes 2018-08-28 15:13:05 -07:00
git_review tests/__init__.py: ssh-keygen -m PEM for bouncycastle 2018-12-04 18:12:06 -08:00
releasenotes/notes Start using reno for releasenotes 2018-08-28 15:13:05 -07:00
.gitignore Ignore .eggs cruft 2015-06-17 00:56:40 +00:00
.gitreview Updated .gitreview location 2012-12-16 10:40:51 -08:00
.mailmap Migrate to pbr. 2013-08-15 20:42:37 +00:00
.testr.conf Implement integration tests. 2013-08-15 21:08:08 +00:00
CONTRIBUTING.rst Add a note about contribution priorities 2017-11-17 03:46:01 +00:00
HACKING.rst Fix one typo on git-review documentation 2015-08-10 11:18:58 +09:00
LICENSE Ported rfc.sh to a standalone program. 2011-09-25 09:16:31 -07:00
MANIFEST.in Migrate to pbr. 2013-08-15 20:42:37 +00:00
README.rst Fixed a dead link to the git-review docs 2015-06-03 17:09:13 +00:00
bindep.txt Add bindep.txt 2018-01-10 11:11:04 +11:00
git-review.1 Document usepushurl in the man page 2018-03-22 07:04:14 -05:00
requirements.txt Remove argparse from requirements 2016-02-07 12:50:08 +00:00
setup.cfg Correct metadata URLs 2016-02-02 15:52:39 -08:00
setup.py Update requirements to OpenStack's recommendations 2014-07-03 14:54:14 +00:00
test-requirements.txt Use doc/requirements and openstackdocstheme 2018-08-28 15:13:00 -07:00
tox.ini Use doc/requirements and openstackdocstheme 2018-08-28 15:13:00 -07:00

README.rst

git-review

A git command for submitting branches to Gerrit

git-review is a tool that helps submitting git branches to gerrit for review.