From 28d1f2fc3c8be9efabfd3fb4c4bf9bd92cea6e56 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 21 Jul 2016 13:25:39 -0700 Subject: [PATCH] Remove racy portion of rspec test We can't assume bandersnatch hasn't run yet after puppet is done since it runs on a cron it could start running even while puppet is still running. Instead just assert that it does its job after it should have run. This fixes a test failure due to the racyness that existed previously. Change-Id: I3f919c9dbd762c1dc603e24899a7ced16d1165a0 --- spec/acceptance/basic_spec.rb | 6 ------ 1 file changed, 6 deletions(-) diff --git a/spec/acceptance/basic_spec.rb b/spec/acceptance/basic_spec.rb index ed75eff..6ceee4a 100644 --- a/spec/acceptance/basic_spec.rb +++ b/spec/acceptance/basic_spec.rb @@ -34,12 +34,6 @@ describe 'puppet-bandersnatch module' do end describe 'required services' do - # Before bandersnatch has run - describe command('curl localhost') do - its(:stdout) { should contain('Index of /') } - its(:stdout) { should_not contain('simple/') } - end - # Wait for bandersnatch to run describe command('sleep 480 && curl localhost') do its(:stdout) { should contain('Index of /') }