puppet-ethercalc/0d38944e1ffbac6157e9dee113e...

39 lines
2.5 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "3f79a3b5_df0b657a",
"filename": "manifests/init.pp",
"patchSetId": 3
},
"lineNbr": 116,
"author": {
"id": 4146
},
"writtenOn": "2018-08-10T17:44:42Z",
"side": 1,
"message": "I don\u0027t think this symlink will work with our existing install.\n\n clarkb@ethercalc01:~$ ls -l /opt/ethercalc/node_modules/ethercalc/node_modules\n total 52\n drwxr-xr-x 5 root root 4096 Feb 14 2017 cors\n drwxr-xr-x 6 root root 4096 Feb 14 2017 csv-parse\n drwxr-xr-x 4 root root 4096 Feb 14 2017 iconv-lite\n drwxr-xr-x 4 root root 4096 Feb 14 2017 j\n drwxr-xr-x 5 root root 4096 Feb 14 2017 livescript\n drwxr-xr-x 3 root root 4096 Feb 14 2017 minimatch\n drwxr-xr-x 4 root root 4096 Feb 14 2017 nodemailer\n drwxr-xr-x 5 root root 4096 Feb 14 2017 optimist\n drwxr-xr-x 3 root root 4096 Feb 14 2017 redis\n drwxr-xr-x 3 root root 4096 Feb 14 2017 socialcalc\n drwxr-xr-x 3 root root 4096 Feb 14 2017 uuid-pure\n drwxr-xr-x 4 root root 4096 Feb 14 2017 xoauth2\n drwxr-xr-x 5 root root 4096 Feb 14 2017 zappajs\n clarkb@ethercalc01:~$ ls -l /opt/ethercalc/node_modules/\n total 4\n drwxr-xr-x 16 root root 4096 Feb 14 2017 ethercalc\n\nWe will end up targeting a directory that doesn\u0027t exist. Can we turn this into a conditional that adds the symlink if /opt/ethercalc/node_modules/ethercalc/node_modules/socialcalc does not exist? Maybe using an exec with an onlyif?",
"revId": "0d38944e1ffbac6157e9dee113e2f8bbc10df08e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_3d9dbebb",
"filename": "manifests/init.pp",
"patchSetId": 3
},
"lineNbr": 116,
"author": {
"id": 8482
},
"writtenOn": "2018-08-10T20:07:55Z",
"side": 1,
"message": "I don\u0027t understand your example. Remember that the target is the symlink that\u0027s going to be created, whereas the name of the resource is the source of the link. Your ls shows that the source, socialcalc, exists in the right directory, and also that the target directory, ethercalc, also exists, so I am pretty much certain that this is correct. Moreover, the tests prove that this should work.",
"parentUuid": "3f79a3b5_df0b657a",
"revId": "0d38944e1ffbac6157e9dee113e2f8bbc10df08e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}