From ad5cc1f3576cebee57d1e74eb8c7c3daad492307 Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Mon, 18 Dec 2017 15:22:58 +1100
Subject: [PATCH] Don't install npm dependencies in /var/log

The ${epuser} home directory is being set to ${base_log_dir} which
results in the npm dependencies being installed into /var/log.

Create a regular homedir for the user (it's not put under
${base_install_dir} because we want that owned by the user, which is a
race).

Change-Id: I0020468ec275c7f12f038f5a152fe9adab64a3e8
---
 manifests/init.pp | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/manifests/init.pp b/manifests/init.pp
index 79d9cfa..b36c1c0 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -26,11 +26,11 @@ class etherpad_lite (
   $path = "/usr/local/bin:/usr/bin:/bin:${base_install_dir}/etherpad-lite"
 
   user { $ep_user:
-    shell   => '/usr/sbin/nologin',
-    home    => "${base_log_dir}/${ep_user}",
-    system  => true,
-    gid     => $ep_user,
-    require => Group[$ep_user],
+    shell      => '/usr/sbin/nologin',
+    system     => true,
+    gid        => $ep_user,
+    require    => Group[$ep_user],
+    managehome => true,
   }
 
   group { $ep_user:
@@ -95,11 +95,12 @@ class etherpad_lite (
     path        => $path,
     user        => $ep_user,
     cwd         => "${base_install_dir}/etherpad-lite",
-    environment => "HOME=${base_log_dir}/${ep_user}",
+    environment => "HOME=/home/${ep_user}",
     require     => [
       Package['curl'],
       Vcsrepo["${base_install_dir}/etherpad-lite"],
       Anchor['nodejs-anchor'],
+      User[$ep_user],
     ],
     before      => File["${base_install_dir}/etherpad-lite/settings.json"],
     creates     => "${base_install_dir}/etherpad-lite/node_modules",