Update patch set 19

Patch Set 19: Code-Review-1

(3 comments)

Patch-set: 19
Label: Code-Review=-1

bd6c064c16071a7893731968590370469fd0cc78

@@ -0,0 +1,55 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5a74a57a_1034ecf9",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 19
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2016-11-28T22:32:52Z",
+      "side": 1,
+      "message": "\u0027template\u0027 here isn\u0027t correct, and changing it to use a template would break backwards compatibility.\n\nThe net effect of this patch is really to make the current jenkins config file a template so that it can be customized OR to pass in your own full (non-template) config file.",
+      "revId": "bd6c064c16071a7893731968590370469fd0cc78",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a74a57a_b0d978f5",
+        "filename": "manifests/master.pp",
+        "patchSetId": 19
+      },
+      "lineNbr": 5,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2016-11-28T22:32:52Z",
+      "side": 1,
+      "message": "I think it would be helpful to include the config filename in the comment: /etc/default/jenkins\n\nAlso, need to clarify when it\u0027s used as a file(source) and when it\u0027s used as a template(content).",
+      "revId": "bd6c064c16071a7893731968590370469fd0cc78",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a74a57a_f071300d",
+        "filename": "manifests/master.pp",
+        "patchSetId": 19
+      },
+      "lineNbr": 22,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2016-11-28T22:32:52Z",
+      "side": 1,
+      "message": "I think this comment is misleading/incorrect. The puppet code treats it as source \u003d\u003e $jenkins_default will copy the contents of the file to /etc/default/jenkins\n\nhttps://docs.puppet.com/puppet/latest/reference/types/file.html#file-attribute-source",
+      "revId": "bd6c064c16071a7893731968590370469fd0cc78",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}