Update patch set 5

Patch Set 5: Code-Review-1

(1 comment)

Note inline that I think will need to be fixed up (hence -1).

I see the comment on an earlier change that caused you to make the change, but don't like using generic /srv/www/paste. We used to host two instances of lodgeit on this server, support for which I believe is why ${name} was used in general.

Since we've already gone this far to support separate instances of lodgeit on the same server, I think we should continue that with the installation of the optional robots.txt.

Patch-set: 5
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6609 2015-10-07 23:33:11 +00:00 committed by Gerrit Code Review
parent e7256efdc2
commit 3f43e5f824
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "7a2fa921_c9434541",
"filename": "manifests/site.pp",
"patchSetId": 5
},
"lineNbr": 21,
"author": {
"id": 6609
},
"writtenOn": "2015-10-07T23:33:11Z",
"side": 1,
"message": "This one is still ${name}, even though the others have been changed to paste/",
"revId": "d0c51e12813a9d7c47a2f7ee776af68f9c8c14ce",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}