opendev
/
puppet-lodgeit
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Odd, I would have expected jenkins to fail because of the order of params in mysql.pp

Patch-set: 1
This commit is contained in:
Gerrit User 4162 2015-10-15 17:20:07 +00:00 committed by Gerrit Code Review
parent dea64ea0eb
commit 5b126a8142
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
b1cb51e8643fd5b802665bef8f7f412c5f65b129 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "5a2ca52d_6e9d4ebb",
"filename": "manifests/mysql.pp",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 4162
},
"writtenOn": "2015-10-15T17:20:07Z",
"side": 1,
"message": "this needs to be below root_password, puppet-lint should have caught this.",
"revId": "b1cb51e8643fd5b802665bef8f7f412c5f65b129",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a2ca52d_8ea22afc",
"filename": "manifests/mysql.pp",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 4162
},
"writtenOn": "2015-10-15T17:20:07Z",
"side": 1,
"message": "might as well expose host since you are at it.",
"revId": "b1cb51e8643fd5b802665bef8f7f412c5f65b129",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a2ca52d_2ea3d601",
"filename": "templates/manage.py.erb",
"patchSetId": 1
},
"lineNbr": 10,
"author": {
"id": 4162
},
"writtenOn": "2015-10-15T17:20:07Z",
"side": 1,
"message": "Did you also want to expose port?",
"revId": "b1cb51e8643fd5b802665bef8f7f412c5f65b129",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}