Remove idempotency spec checks

The idempotency checks race external changes like updates to
project-config or nodepool. This often causes this job to fail when we
are busy updating other parts of our sytems.

Idempotency is nice but not necessary. Lets remove these checks to make
testing more reliable.

Change-Id: I1092b3a2f4b781465c2148336076677d3c07211e

spec/acceptance/basic_spec.rb

@@ -12,9 +12,7 @@ describe 'basic openstackci' do
         pp_path = File.join(base_path, 'fixtures', 'default.pp')
         pp = File.read(pp_path)
 
-        # Run it twice and test for idempotency
         apply_manifest(pp, :catch_failures => true)
-        apply_manifest(pp, :catch_changes => true)
       end
 
     end

spec/acceptance/nodepool_builder_spec.rb

@@ -35,10 +35,6 @@ describe 'nodepool builder', :if => (
     apply_manifest(puppet_manifest, catch_failures: true)
   end
 
-  it 'should be idempotent' do
-    apply_manifest(puppet_manifest, catch_changes: true)
-  end
-
   it 'should start' do
     apply_manifest(postconditions_puppet_manifest, catch_failures: true)
   end

spec/acceptance/nodepool_launcher_spec.rb

@@ -35,10 +35,6 @@ describe 'nodepool launcher', :if => (
     apply_manifest(puppet_manifest, catch_failures: true)
   end
 
-  it 'should be idempotent' do
-    apply_manifest(puppet_manifest, catch_changes: true)
-  end
-
   it 'should start' do
     apply_manifest(postconditions_puppet_manifest, catch_failures: true)
   end