opendev
/
puppet-stackalytics
Code Issues Proposed changes

Update patch set 21 

Patch Set 21: Code-Review-1

(3 comments)

Patch-set: 21
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6133 2015-10-27 23:22:13 +00:00 committed by Gerrit Code Review
parent d1c8ef21c3
commit 515d3dbe03
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
32ad3fccbcd153ccced6237a415d7bba8a8ae33e Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "1a26ad4f_716361b2",
"filename": "manifests/init.pp",
"patchSetId": 21
},
"lineNbr": 162,
"author": {
"id": 6133
},
"writtenOn": "2015-10-27T23:22:13Z",
"side": 1,
"message": "you need to use httpd::mod now",
"revId": "32ad3fccbcd153ccced6237a415d7bba8a8ae33e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a26ad4f_1158edf9",
"filename": "templates/stackalytics.vhost.erb",
"patchSetId": 21
},
"lineNbr": 9,
"author": {
"id": 6133
},
"writtenOn": "2015-10-27T23:22:13Z",
"side": 1,
"message": "this will work only for apache 2.4 or greater, do we want to limit the module to these versions?",
"revId": "32ad3fccbcd153ccced6237a415d7bba8a8ae33e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a26ad4f_510505c0",
"filename": "templates/uwsgi.ini.erb",
"patchSetId": 21
},
"lineNbr": 9,
"author": {
"id": 6133
},
"writtenOn": "2015-10-27T23:22:13Z",
"side": 1,
"message": "why is that a template if it has no placeholders to replace? if not needed, it should be a file",
"revId": "32ad3fccbcd153ccced6237a415d7bba8a8ae33e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}