From 1a13f760edc3096c3c4be769ddbdda565bd8db92 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Fri, 9 Jun 2017 06:59:31 -0700 Subject: [PATCH] Fix lint issues This fixes linter issues with parameter ordering. Required parameters must come first. Change-Id: I31f1cc51ade2ac95087af3b2cdc8843396c23c12 --- manifests/init.pp | 5 ++--- manifests/mysql.pp | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/manifests/init.pp b/manifests/init.pp index 683fdcf..bf6a3db 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -16,11 +16,12 @@ # class zanata( + $zanata_default_from_address, + $zanata_db_password, $mysql_host = 'localhost', $mysql_port = '3306', $zanata_db_name = 'zanata', $zanata_db_username = 'zanata', - $zanata_db_password, # For wildfly < 10 the zanata_url below is expected to be a url to a built # war for wildfly >=10 the expectation is that it is the url to one of the @@ -38,7 +39,6 @@ class zanata( # This should be a sha1 of whatever file is hosted at the url above. $zanata_checksum = '59f1ac35cce46ba4e46b06a239cd7ab4e10b5528', - $zanata_default_from_address, $zanata_storage_dir = '/home/wildfly/zanata', $zanata_openid_provider_url = '', @@ -52,7 +52,6 @@ class zanata( $zanata_smtp_password = '', $zanata_smtp_tls = '', $zanata_smtp_ssl = '', - ) { zanata::validate_listener { $zanata_listeners: } diff --git a/manifests/mysql.pp b/manifests/mysql.pp index f18c5c5..9e7608d 100644 --- a/manifests/mysql.pp +++ b/manifests/mysql.pp @@ -15,14 +15,13 @@ # == Class: zanata::mysql # class zanata::mysql( + $db_password, $mysql_root_password = '', $mysql_host = 'localhost', $mysql_bind_address = '127.0.0.1', $mysql_port = '3306', $db_name = 'zanata', $db_username = 'zanata', - $db_password, - ) { class { '::mysql::server':