opendev
/
storyboard-webclient
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
This commit is contained in:
Gerrit User 5263 2019-10-17 21:24:44 +00:00 committed by Gerrit Code Review
parent a755280fe0
commit 19733c35d5
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
8caf5fced66abb37118ff33d55d156374dd7c4bc Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "3fa7e38b_0e1f0c71",
"filename": "src/app/util/template/user_typeahead.html",
"patchSetId": 6
},
"lineNbr": 12,
"author": {
"id": 5263
},
"writtenOn": "2019-10-17T21:24:44Z",
"side": 1,
"message": "This edit has introduced an extra space before the closing tag for the span. I have no idea whether that actually matters. also it incorporates a hard tab in the indentation.",
"revId": "8caf5fced66abb37118ff33d55d156374dd7c4bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_ae2b5893",
"filename": "src/app/util/template/user_typeahead.html",
"patchSetId": 6
},
"lineNbr": 52,
"author": {
"id": 5263
},
"writtenOn": "2019-10-17T21:24:44Z",
"side": 1,
"message": "What does switching from user.full_name to formatUserName(user) do here? Is this for improved consistency with the input formatter below?",
"revId": "8caf5fced66abb37118ff33d55d156374dd7c4bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}