Enabled eslint:no-underscore-dangle

Rule enabled, discovered issues resolved.

Change-Id: If5fc53b0f1a6c3a31b4ef8b1858f4ef5d3ea0016

.eslintrc

@@ -58,7 +58,6 @@
         "space-unary-ops": 0,
         "no-console": 0,
         "strict": 0,
-        "no-underscore-dangle": 0,
 
         // Stylistic
         "indent": [2, 4],

src/app/services/provider/preference.js

@@ -61,7 +61,7 @@ angular.module('sb.services').provider('Preference',
              *
              * @returns {deferred.promise|*}
              */
-            this._resolveUserPreferences = function () {
+            this.resolveUserPreferences = function () {
                 var deferred = $q.defer();
 
                 // First resolve the session.
@@ -118,7 +118,7 @@ angular.module('sb.services').provider('Preference',
                         }
                     }
                 }
-                return this._save();
+                return this.save();
             };
 
             /**
@@ -158,7 +158,7 @@ angular.module('sb.services').provider('Preference',
                 // Store the preference.
                 preferences[key] = value;
 
-                return this._save();
+                return this.save();
             };
 
             /**
@@ -168,7 +168,7 @@ angular.module('sb.services').provider('Preference',
                 var deferred = $q.defer();
 
                 // This should never fail, see implementation above.
-                this._resolveUserPreferences().then(
+                this.resolveUserPreferences().then(
                     function (newPrefs) {
                         preferences = newPrefs;
                         deferred.resolve(preferences);
@@ -181,7 +181,7 @@ angular.module('sb.services').provider('Preference',
             /**
              * Private save method.
              */
-            this._save = function () {
+            this.save = function () {
                 var deferred = $q.defer();
 
                 // If preferences are defaults, they won't have a $save()

src/app/util/service/last_location.js

@@ -50,7 +50,7 @@ angular.module('sb.util')
             /**
              * Initialize this service.
              */
-            _initialize: function () {
+            initialize: function () {
                 // Register (and disconnect) our listener.
                 $rootScope.$on('$destroy',
                     $rootScope.$on('$locationChangeStart', onLocationChange)
@@ -62,5 +62,5 @@ angular.module('sb.util')
         'use strict';
 
         // Initialize this service.
-        LastLocation._initialize();
+        LastLocation.initialize();
     });