opendev
/
system-config
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+2

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 80d819d5b1353fcbc27a56dfa88b9f57f4ea567d
Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 12898 \u003c12898@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
This commit is contained in:
Gerrit User 4146 2024-05-03 16:29:43 +00:00 committed by Gerrit Code Review
parent cf25e849d1
commit c1fcc282e4
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
09eb145e4b0bdbf6b7c0d3efba79e1eace817178
View File

@ -87,6 +87,24 @@
"parentUuid": "5ee40026_92573d14",
"revId": "09eb145e4b0bdbf6b7c0d3efba79e1eace817178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f2ececd4_2a465de4",
"filename": "playbooks/zuul/templates/group_vars/jvb.yaml.j2",
"patchSetId": 3
},
"lineNbr": 1,
"author": {
"id": 4146
},
"writtenOn": "2024-05-03T16:29:43Z",
"side": 1,
"message": "I don\u0027t think we need a value on bridge because https://review.opendev.org/c/opendev/system-config/+/905510/4/playbooks/roles/jitsi-meet/defaults/main.yaml sets a value that works for production in the role defaults. We only need the override in the test environment because meetpad.o.o isn\u0027t defined there but meetpad01 is.",
"parentUuid": "94a1e770_af0a081b",
"revId": "09eb145e4b0bdbf6b7c0d3efba79e1eace817178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}