openstack
/
ansible-config_template
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
CC: Gerrit User 28619 <28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
This commit is contained in:
Gerrit User 28619 2022-06-20 10:51:43 +00:00 committed by Gerrit Code Review
parent 24169f67d2
commit 8fb91c98fe
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
aeefe7d92a9917c6daebd419be1f6b731fc764d8
View File

@ -108,6 +108,30 @@
},
"revId": "aeefe7d92a9917c6daebd419be1f6b731fc764d8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4d56a50b_5ed47c41",
"filename": "doc/source/index.rst",
"patchSetId": 4
},
"lineNbr": 79,
"author": {
"id": 28619
},
"writtenOn": "2022-06-20T10:51:43Z",
"side": 1,
"message": "I think I\u0027m missing some scope of the discussion here as feels that there\u0027s intended to be some extra use-case for config_tempalte ansible module then it is right now.\n\nBut to have that said, with this specific exemple, we in OSA would indeed provide just a string to the module, like:\n\n nova_nova_conf_overrides:\n pci: \u0027{ \"physical_network\": \"\u003cml2 network name\u003e\", \"devname\": \"\u003cphysical nic\u003e\" }\u0027\n \nBut we also have an independent variable for that inside nova.conf.j2 template (that still can be overwritten with this module).",
"parentUuid": "efca2dbf_30b657cb",
"range": {
"startLine": 77,
"startChar": 2,
"endLine": 79,
"endChar": 32
},
"revId": "aeefe7d92a9917c6daebd419be1f6b731fc764d8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}