Update patch set 4
Patch Set 4: (4 comments) Patch-set: 4 CC: Gerrit User 11604 <11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 6816 \u003c6816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"sean mooney replied on the change"}
This commit is contained in:
parent
181dab496e
commit
9979ebcbe5
|
@ -0,0 +1,90 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "72d4d63e_b749ab9e",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 11604
|
||||
},
|
||||
"writtenOn": "2022-06-14T17:24:11Z",
|
||||
"side": 1,
|
||||
"message": "this looks promising\n\nmost other moduels i have seen have not supported multiopts properly.\n\nnova support multistropts where the values are strings conatining json\nand when parsed they form a list of string each of which has json embeded.\n\nthe data within a multiopt sting is and should be opaque to the cofnig module and preserved as is as\nquoting may be important as it is with the embeded json cases.",
|
||||
"revId": "aeefe7d92a9917c6daebd419be1f6b731fc764d8",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "908bb711_cace8b79",
|
||||
"filename": "doc/source/index.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 11604
|
||||
},
|
||||
"writtenOn": "2022-06-14T17:24:11Z",
|
||||
"side": 1,
|
||||
"message": "these are both just setting simple value but syalistically i think you shoudl be quoting the values as you are implictly relying on them being converted to strings\n\nif you used true for example that shoudl be interpreated as a boolean not a string.\nwhere as \"bool\" ture would shoudl preserve the quotes.",
|
||||
"range": {
|
||||
"startLine": 48,
|
||||
"startChar": 1,
|
||||
"endLine": 51,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "aeefe7d92a9917c6daebd419be1f6b731fc764d8",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6ae268c5_52d5fbea",
|
||||
"filename": "doc/source/index.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 55,
|
||||
"author": {
|
||||
"id": 11604
|
||||
},
|
||||
"writtenOn": "2022-06-14T17:24:11Z",
|
||||
"side": 1,
|
||||
"message": "this is a simple ordered list\nand shoudl be used when ordring of the items is important such as schduler filters.",
|
||||
"range": {
|
||||
"startLine": 53,
|
||||
"startChar": 0,
|
||||
"endLine": 55,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "aeefe7d92a9917c6daebd419be1f6b731fc764d8",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0b2ccd88_16412b26",
|
||||
"filename": "doc/source/index.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 11604
|
||||
},
|
||||
"writtenOn": "2022-06-14T17:24:11Z",
|
||||
"side": 1,
|
||||
"message": "ack \nthis is technially an unsorted set in yaml terms\n\nhttps://yaml.org/spec/1.2.2/#example-unordered-sets\n\n\ni think order ist technially undefined for multi ops but in pratces its preserved in oslo.config i belive when the values fo the multi opt are merged into a list of values.\n\nnone of the usages im aware of for multiOpts in openstack depend on order and i would suggest listOpt is a much better choice when order is requried.\n\nso this syntax i think makes logical sense.",
|
||||
"range": {
|
||||
"startLine": 57,
|
||||
"startChar": 0,
|
||||
"endLine": 59,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "aeefe7d92a9917c6daebd419be1f6b731fc764d8",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue