openstack
/
ansible-config_template
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 32666 \u003c32666@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32666\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32666\u003e replied on the change"}
This commit is contained in:
Gerrit User 32666 2023-05-01 10:38:43 +00:00 committed by Gerrit Code Review
parent 7011b3f2d6
commit 9aa32627d2
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
d1fe5734ae7b91a995f014610ab494555266ccf4
View File

@ -70,6 +70,24 @@
"parentUuid": "56e818d9_06236bec",
"revId": "d1fe5734ae7b91a995f014610ab494555266ccf4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "869139f0_f5bf8fea",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 32666
},
"writtenOn": "2023-05-01T10:38:43Z",
"side": 1,
"message": "disregard what i wrote before, my playbook was broken, sorry for that :|\n\nI found another thing but I\u0027ll create a separate comment for that.",
"parentUuid": "348ebe6e_725d12ec",
"revId": "d1fe5734ae7b91a995f014610ab494555266ccf4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
e528ed0e9e9f3d3fcb2f33ddc5d175faf72094ac Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "f831acb8_6fae9a02",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 32666
},
"writtenOn": "2023-05-01T10:38:43Z",
"side": 1,
"message": "I don\u0027t know if it makes any difference but just to be aware of it:\n\nif you compare \u0027template\u0027 and \u0027config_template\u0027 plugins there is one difference:\nbuilt-in \u0027template\u0027 plugin preserves `\"` while config_template changes `\"` to `\u0027`\n\nhttps://paste.openstack.org/show/bJpd8YbsTjEfFdsBjJz2/",
"revId": "e528ed0e9e9f3d3fcb2f33ddc5d175faf72094ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}