openstack
/
ansible-role-chrony
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
CC: Gerrit User 30073 <30073@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 30073 2022-06-02 01:11:38 +00:00 committed by Gerrit Code Review
parent 7d6d073e17
commit 6497245ef3
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
f7833d0d30236c2d7f7147f2145883777fc658bc Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "42b20970_09168ae0",
"filename": "tasks/install.yml",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 30073
},
"writtenOn": "2022-06-02T01:11:38Z",
"side": 1,
"message": "I guess it\u0027s not overly important, but we shouldn\u0027t need priv escalation for this task.",
"revId": "f7833d0d30236c2d7f7147f2145883777fc658bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1dad0025_64dc6876",
"filename": "tasks/install.yml",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 30073
},
"writtenOn": "2022-06-02T01:11:38Z",
"side": 1,
"message": "But this one will need priv escalation to stop the service. So if we\u0027re running this as a non-root user, that become from above will need to be moved here instead.",
"revId": "f7833d0d30236c2d7f7147f2145883777fc658bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}