openstack
/
ansible-role-redhat-subscription
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(5 comments)

Patch-set: 5
CC: Gerrit User 6816 <6816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 7130 \u003c7130@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Jesse Pretorius replied on the change"}
This commit is contained in:
Gerrit User 6816 2022-06-07 13:25:55 +00:00 committed by Gerrit Code Review
parent 8818563b95
commit c6eddbb274
1 changed files with 101 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

101
ba2ec17ffa98960b1321ba6f75afb76592bbf901 Normal file
View File

@ -0,0 +1,101 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "804f31e3_111e44fe",
"filename": "tasks/satellite.yml",
"patchSetId": 5
},
"lineNbr": 13,
"author": {
"id": 6816
},
"writtenOn": "2022-06-07T13:25:55Z",
"side": 1,
"message": "I would think we need to remove \u0027ignore_errors: true\u0027 here, assuming that 200/404 are the only expected returns from the service.",
"revId": "ba2ec17ffa98960b1321ba6f75afb76592bbf901",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0c125fc5_8f34efcf",
"filename": "tasks/satellite.yml",
"patchSetId": 5
},
"lineNbr": 29,
"author": {
"id": 6816
},
"writtenOn": "2022-06-07T13:25:55Z",
"side": 1,
"message": "I would think we need to remove \u0027ignore_errors: true\u0027 here, assuming that 200/404 are the only expected returns from the service.",
"revId": "ba2ec17ffa98960b1321ba6f75afb76592bbf901",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a3e5ecdb_4b2eeb84",
"filename": "tasks/satellite.yml",
"patchSetId": 5
},
"lineNbr": 32,
"author": {
"id": 6816
},
"writtenOn": "2022-06-07T13:25:55Z",
"side": 1,
"message": "This conditional is likely not needed. We can check for both, then decide which to use.",
"revId": "ba2ec17ffa98960b1321ba6f75afb76592bbf901",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ae48c0e7_f4282e05",
"filename": "tasks/satellite.yml",
"patchSetId": 5
},
"lineNbr": 63,
"author": {
"id": 6816
},
"writtenOn": "2022-06-07T13:25:55Z",
"side": 1,
"message": "Could this all be squashed into simply checking for the v3 api endpoint, then perhaps an assertion that the status code is 404?",
"range": {
"startLine": 34,
"startChar": 0,
"endLine": 63,
"endChar": 45
},
"revId": "ba2ec17ffa98960b1321ba6f75afb76592bbf901",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3420d59f_eb3e049e",
"filename": "tasks/satellite.yml",
"patchSetId": 5
},
"lineNbr": 90,
"author": {
"id": 6816
},
"writtenOn": "2022-06-07T13:25:55Z",
"side": 1,
"message": "This could be squashed into a single set_fact and some jinja script to populate it, something like:\n\n - name: SATELLITE | Set Satellite version\n set_fact: \u003e-\n {%- if _sat5_check.status \u003d\u003d 200 %}\n rhsm_satellite_version: 5\n {%- elif _sat6_check.status \u003d\u003d 200 %}\n rhsm_satellite_version: 6\n {%- endif %}\n tags:\n - rhsm_satellite",
"range": {
"startLine": 76,
"startChar": 0,
"endLine": 90,
"endChar": 20
},
"revId": "ba2ec17ffa98960b1321ba6f75afb76592bbf901",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}