diff --git a/src/lib/charm/vault_utils.py b/src/lib/charm/vault_utils.py index 405bf24..caa6d0a 100644 --- a/src/lib/charm/vault_utils.py +++ b/src/lib/charm/vault_utils.py @@ -23,6 +23,5 @@ def retrieve_secret_id(url, token): # "error decrementing wrapping token's use-count: invalid token entry # provided for use count decrementing" response = client._post('/v1/sys/wrapping/unwrap') - if response.status_code == 200: - data = response.json() - return data['data']['secret_id'] + if response.get("data"): + return response['data']['secret_id'] diff --git a/unit_tests/test_vault_utils.py b/unit_tests/test_vault_utils.py index 5725e20..fbbe43c 100644 --- a/unit_tests/test_vault_utils.py +++ b/unit_tests/test_vault_utils.py @@ -25,9 +25,7 @@ class TestVaultUtils(test_utils.PatchHelper): self.patch_object(vault_utils, 'hvac') hvac_client = mock.MagicMock() self.hvac.Client.return_value = hvac_client - response = mock.MagicMock() - response.status_code = 200 - response.json.return_value = {'data': {'secret_id': 'FAKE_SECRET_ID'}} + response = {'data': {'secret_id': 'FAKE_SECRET_ID'}} hvac_client._post.return_value = response self.assertEqual( vault_utils.retrieve_secret_id('url', 'token'), 'FAKE_SECRET_ID')