openstack
/
charm-cinder
Code Issues Proposed changes

Import CONFIGS instead of calling register_configs() again.

This commit is contained in:
Corey Bryant 2015-09-22 21:03:02 +00:00
parent cf85c97623
commit d02007359d
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
actions/openstack_upgrade.py
View File

@ -13,17 +13,16 @@ from charmhelpers.core.hookenv import (
relation_set,
)
from cinder_hooks import config_changed
from cinder_hooks import (
config_changed,
CONFIGS,
)
from cinder_utils import (
do_openstack_upgrade,
register_configs
)
CONFIGS = register_configs()
def openstack_upgrade():
"""Upgrade packages to config-set Openstack version.

7
unit_tests/test_actions_openstack_upgrade.py
View File

@ -13,7 +13,6 @@ from test_utils import (
TO_PATCH = [
'config_changed',
'do_openstack_upgrade',
'register_configs',
'relation_set',
'relation_ids',
'uuid'
@ -26,12 +25,13 @@ class TestCinderUpgradeActions(CharmTestCase):
super(TestCinderUpgradeActions, self).setUp(openstack_upgrade,
TO_PATCH)
@patch('charmhelpers.contrib.openstack.utils.juju_log')
@patch('charmhelpers.contrib.openstack.utils.config')
@patch('charmhelpers.contrib.openstack.utils.action_set')
@patch('charmhelpers.contrib.openstack.utils.git_install_requested')
@patch('charmhelpers.contrib.openstack.utils.openstack_upgrade_available')
def test_openstack_upgrade_true(self, upgrade_avail, git_requested,
action_set, config):
action_set, config, log):
git_requested.return_value = False
upgrade_avail.return_value = True
config.return_value = True
@ -46,12 +46,13 @@ class TestCinderUpgradeActions(CharmTestCase):
upgrade_nonce=12345)
self.assertTrue(self.config_changed.called)
@patch('charmhelpers.contrib.openstack.utils.juju_log')
@patch('charmhelpers.contrib.openstack.utils.config')
@patch('charmhelpers.contrib.openstack.utils.action_set')
@patch('charmhelpers.contrib.openstack.utils.git_install_requested')
@patch('charmhelpers.contrib.openstack.utils.openstack_upgrade_available')
def test_openstack_upgrade_false(self, upgrade_avail, git_requested,
action_set, config):
action_set, config, log):
git_requested.return_value = False
upgrade_avail.return_value = True
config.return_value = False