Update patch set 1

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 1131 <1131@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e7da48ffd2502045e2e44dfcd8b7957778df6021
Attention: {"person_ident":"Gerrit User 34275 \u003c34275@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1131\u003e replied on the change"}

da1636dedcef3960ae84f89ecf83a67fb7c1e032

@@ -0,0 +1,55 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "0e494ebc_aa9d8aa7",
+        "filename": "hooks/glance_contexts.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 325,
+      "author": {
+        "id": 1131
+      },
+      "writtenOn": "2024-03-21T17:11:39Z",
+      "side": 1,
+      "message": "This will just return None, so isn\u0027t really needed with below return. But if that\u0027s the case we probably don\u0027t even need this function at all.",
+      "revId": "da1636dedcef3960ae84f89ecf83a67fb7c1e032",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "db627969_c01871f1",
+        "filename": "hooks/glance_contexts.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 378,
+      "author": {
+        "id": 1131
+      },
+      "writtenOn": "2024-03-21T17:11:39Z",
+      "side": 1,
+      "message": "I think this can just be this based on above comments:\n\nkeystone_ctx \u003d IdentityServiceContext()()",
+      "revId": "da1636dedcef3960ae84f89ecf83a67fb7c1e032",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e165a206_39b021a8",
+        "filename": "unit_tests/test_glance_contexts.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 392,
+      "author": {
+        "id": 1131
+      },
+      "writtenOn": "2024-03-21T17:11:39Z",
+      "side": 1,
+      "message": "Just pointing out that some of the unit tests in other charms create a dummy class to do this:\n\nhttps://opendev.org/openstack/charm-neutron-api/src/branch/master/unit_tests/test_neutron_api_utils.py#L89\n\nThe heat charm does it like this, has the same effect.",
+      "revId": "da1636dedcef3960ae84f89ecf83a67fb7c1e032",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}