964 lines
41 KiB
Python
964 lines
41 KiB
Python
# Copyright 2016 Canonical Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import os
|
|
import sys
|
|
import yaml
|
|
|
|
from mock import call, patch, MagicMock
|
|
from test_utils import CharmTestCase
|
|
|
|
# python-apt is not installed as part of test-requirements but is imported by
|
|
# some charmhelpers modules so create a fake import.
|
|
mock_apt = MagicMock()
|
|
sys.modules['apt'] = mock_apt
|
|
mock_apt.apt_pkg = MagicMock()
|
|
|
|
os.environ['JUJU_UNIT_NAME'] = 'glance'
|
|
import hooks.glance_utils as utils # noqa
|
|
|
|
_reg = utils.register_configs
|
|
_map = utils.restart_map
|
|
|
|
utils.register_configs = MagicMock()
|
|
utils.restart_map = MagicMock()
|
|
|
|
with patch('hooks.charmhelpers.contrib.hardening.harden.harden') as mock_dec:
|
|
with patch('hooks.charmhelpers.contrib.openstack.'
|
|
'utils.os_requires_version') as mock_os:
|
|
mock_dec.side_effect = (lambda *dargs, **dkwargs: lambda f:
|
|
lambda *args, **kwargs: f(*args, **kwargs))
|
|
mock_os.side_effect = (lambda *dargs, **dkwargs: lambda f:
|
|
lambda *args, **kwargs: f(*args, **kwargs))
|
|
import hooks.glance_relations as relations
|
|
|
|
relations.hooks._config_save = False
|
|
|
|
utils.register_configs = _reg
|
|
utils.restart_map = _map
|
|
|
|
TO_PATCH = [
|
|
# charmhelpers.core.hookenv
|
|
'Hooks',
|
|
'config',
|
|
'juju_log',
|
|
'is_relation_made',
|
|
'local_unit',
|
|
'open_port',
|
|
'relation_ids',
|
|
'relation_set',
|
|
'relation_get',
|
|
'related_units',
|
|
'service_name',
|
|
# charmhelpers.core.host
|
|
'apt_install',
|
|
'apt_update',
|
|
'restart_on_change',
|
|
'service_reload',
|
|
'service_stop',
|
|
'service_restart',
|
|
# charmhelpers.contrib.openstack.utils
|
|
'configure_installation_source',
|
|
'os_release',
|
|
'openstack_upgrade_available',
|
|
# charmhelpers.contrib.openstack.ha.utils
|
|
'update_dns_ha_resource_params',
|
|
# charmhelpers.contrib.hahelpers.cluster_utils
|
|
'is_elected_leader',
|
|
# hooks.glance_utils
|
|
'restart_map',
|
|
'register_configs',
|
|
'do_openstack_upgrade',
|
|
'migrate_database',
|
|
'ensure_ceph_keyring',
|
|
'ceph_config_file',
|
|
'git_install',
|
|
'update_nrpe_config',
|
|
'reinstall_paste_ini',
|
|
# other
|
|
'call',
|
|
'check_call',
|
|
'execd_preinstall',
|
|
'lsb_release',
|
|
'filter_installed_packages',
|
|
'get_hacluster_config',
|
|
'get_netmask_for_address',
|
|
'get_iface_for_address',
|
|
'sync_db_with_multi_ipv6_addresses',
|
|
'delete_keyring',
|
|
'get_relation_ip',
|
|
]
|
|
|
|
|
|
class GlanceRelationTests(CharmTestCase):
|
|
|
|
def setUp(self):
|
|
super(GlanceRelationTests, self).setUp(relations, TO_PATCH)
|
|
self.config.side_effect = self.test_config.get
|
|
|
|
@patch.object(utils, 'config')
|
|
@patch.object(utils, 'token_cache_pkgs')
|
|
@patch.object(utils, 'git_install_requested')
|
|
def test_install_hook(self, git_requested, token_cache_pkgs, util_config):
|
|
token_cache_pkgs.return_value = ['memcached']
|
|
git_requested.return_value = False
|
|
repo = 'cloud:precise-grizzly'
|
|
self.test_config.set('openstack-origin', repo)
|
|
self.service_stop.return_value = True
|
|
relations.install_hook()
|
|
self.configure_installation_source.assert_called_with(repo)
|
|
self.apt_update.assert_called_with(fatal=True)
|
|
self.apt_install.assert_called_with(
|
|
['apache2', 'glance', 'haproxy', 'memcached', 'python-keystone',
|
|
'python-mysqldb', 'python-psycopg2', 'python-six',
|
|
'python-swiftclient', 'uuid'], fatal=True)
|
|
self.assertTrue(self.execd_preinstall.called)
|
|
self.git_install.assert_called_with(None)
|
|
|
|
@patch.object(utils, 'config')
|
|
@patch.object(utils, 'token_cache_pkgs')
|
|
@patch.object(utils, 'git_install_requested')
|
|
def test_install_hook_precise_distro(self, git_requested, token_cache_pkgs,
|
|
util_config):
|
|
token_cache_pkgs.return_value = []
|
|
git_requested.return_value = False
|
|
self.test_config.set('openstack-origin', 'distro')
|
|
self.lsb_release.return_value = {'DISTRIB_RELEASE': 12.04,
|
|
'DISTRIB_CODENAME': 'precise'}
|
|
self.service_stop.return_value = True
|
|
relations.install_hook()
|
|
self.configure_installation_source.assert_called_with(
|
|
"cloud:precise-folsom"
|
|
)
|
|
|
|
@patch.object(utils, 'config')
|
|
@patch.object(utils, 'token_cache_pkgs')
|
|
@patch.object(utils, 'git_install_requested')
|
|
def test_install_hook_git(self, git_requested, token_cache_pkgs,
|
|
util_config):
|
|
git_requested.return_value = True
|
|
repo = 'cloud:trusty-juno'
|
|
openstack_origin_git = {
|
|
'repositories': [
|
|
{'name': 'requirements',
|
|
'repository': 'git://git.openstack.org/openstack/requirements', # noqa
|
|
'branch': 'stable/juno'},
|
|
{'name': 'glance',
|
|
'repository': 'git://git.openstack.org/openstack/glance',
|
|
'branch': 'stable/juno'}
|
|
],
|
|
'directory': '/mnt/openstack-git',
|
|
}
|
|
projects_yaml = yaml.dump(openstack_origin_git)
|
|
self.test_config.set('openstack-origin', repo)
|
|
self.test_config.set('openstack-origin-git', projects_yaml)
|
|
relations.install_hook()
|
|
self.assertTrue(self.execd_preinstall.called)
|
|
self.configure_installation_source.assert_called_with(repo)
|
|
self.apt_update.assert_called_with(fatal=True)
|
|
self.apt_install.assert_called_with(
|
|
['apache2', 'haproxy', 'libffi-dev', 'libmysqlclient-dev',
|
|
'libssl-dev', 'libxml2-dev', 'libxslt1-dev', 'libyaml-dev',
|
|
'openstack-pkg-tools', 'python-dev', 'python-mysqldb',
|
|
'python-pip', 'python-psycopg2', 'python-setuptools',
|
|
'python-six', 'uuid', 'zlib1g-dev'], fatal=True)
|
|
self.git_install.assert_called_with(projects_yaml)
|
|
|
|
def test_db_joined(self):
|
|
self.get_relation_ip.return_value = '10.0.0.1'
|
|
self.is_relation_made.return_value = False
|
|
relations.db_joined()
|
|
self.relation_set.assert_called_with(database='glance',
|
|
username='glance',
|
|
hostname='10.0.0.1')
|
|
self.get_relation_ip.assert_called_with('shared-db', cidr_network=None)
|
|
|
|
def test_postgresql_db_joined(self):
|
|
self.is_relation_made.return_value = False
|
|
relations.pgsql_db_joined()
|
|
self.relation_set.assert_called_with(database='glance'),
|
|
|
|
def test_db_joined_with_postgresql(self):
|
|
self.is_relation_made.return_value = True
|
|
|
|
with self.assertRaises(Exception) as context:
|
|
relations.db_joined()
|
|
self.assertEqual(context.exception.message,
|
|
'Attempting to associate a mysql database when there '
|
|
'is already associated a postgresql one')
|
|
|
|
def test_postgresql_joined_with_db(self):
|
|
self.is_relation_made.return_value = True
|
|
|
|
with self.assertRaises(Exception) as context:
|
|
relations.pgsql_db_joined()
|
|
self.assertEqual(context.exception.message,
|
|
'Attempting to associate a postgresql database when'
|
|
' there is already associated a mysql one')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_missing_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
relations.db_changed()
|
|
self.juju_log.assert_called_with(
|
|
'shared-db relation incomplete. Peer not ready?'
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_postgresql_db_changed_missing_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
relations.pgsql_db_changed()
|
|
self.juju_log.assert_called_with(
|
|
'pgsql-db relation incomplete. Peer not ready?'
|
|
)
|
|
|
|
def _shared_db_test(self, configs, unit_name,
|
|
allowed_units='glance/0 glance/3'):
|
|
self.relation_get.return_value = allowed_units
|
|
self.local_unit.return_value = unit_name
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['shared-db']
|
|
configs.write = MagicMock()
|
|
relations.db_changed()
|
|
|
|
def _postgresql_db_test(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['pgsql-db']
|
|
configs.write = MagicMock()
|
|
relations.pgsql_db_changed()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_allowed(self, configs):
|
|
self._shared_db_test(configs, 'glance/0')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_not_allowed(self, configs):
|
|
self._shared_db_test(configs, 'glance/2')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertFalse(self.migrate_database.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_no_acls(self, configs):
|
|
self._shared_db_test(configs, 'glance/2', None)
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertFalse(self.migrate_database.called)
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_image_service_joined(self, configs, imgsj):
|
|
rids = ['nova-cloud-controller:1', 'nova-compute:1']
|
|
self.relation_ids.return_value = rids
|
|
self._shared_db_test(configs, 'glance/2', None)
|
|
[self.assertIn(call(r), imgsj.call_args_list) for r in rids]
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_postgresql_db_changed_no_essex(self, configs):
|
|
self._postgresql_db_test(configs)
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_with_essex_not_setting_version_control(self, configs):
|
|
self.os_release.return_value = "essex"
|
|
self.call.return_value = 0
|
|
self._shared_db_test(configs, 'glance/0')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_postgresql_db_changed_with_essex_not_setting_version_control(
|
|
self, configs):
|
|
self.os_release.return_value = "essex"
|
|
self.call.return_value = 0
|
|
self._postgresql_db_test(configs)
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_postgresql_db_changed_image_service_joined(self, configs, imgsj):
|
|
rids = ['nova-cloud-controller:1', 'nova-compute:1']
|
|
self.relation_ids.return_value = rids
|
|
self._postgresql_db_test(configs)
|
|
[self.assertIn(call(r), imgsj.call_args_list) for r in rids]
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_with_essex_setting_version_control(self, configs):
|
|
self.os_release.return_value = "essex"
|
|
self.call.return_value = 1
|
|
self._shared_db_test(configs, 'glance/0')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.check_call.assert_called_with(
|
|
["glance-manage", "version_control", "0"]
|
|
)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_postgresql_db_changed_with_essex_setting_version_control(
|
|
self, configs):
|
|
self.os_release.return_value = "essex"
|
|
self.call.return_value = 1
|
|
self._postgresql_db_test(configs)
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.check_call.assert_called_with(
|
|
["glance-manage", "version_control", "0"]
|
|
)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'is_api_ready')
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_image_service_joined_leader(self, _canonical_url, _api_ready):
|
|
_api_ready.return_value = True
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.image_service_joined()
|
|
args = {
|
|
'glance-api-ready': 'yes',
|
|
'glance-api-server': 'http://glancehost:9292',
|
|
'relation_id': None
|
|
}
|
|
self.relation_set.assert_called_with(**args)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_image_service_joined_specified_interface(self, _canonical_url):
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.image_service_joined(relation_id='image-service:1')
|
|
args = {
|
|
'glance-api-ready': 'no',
|
|
'glance-api-server': 'http://glancehost:9292',
|
|
'relation_id': 'image-service:1',
|
|
}
|
|
self.relation_set.assert_called_with(**args)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_without_identity_service(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.juju_log.assert_called_with(
|
|
'Deferring swift storage configuration until '
|
|
'an identity-service relation exists'
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_with_identity_service_without_object_store(
|
|
self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.juju_log.assert_called_with(
|
|
'swift relation incomplete'
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_with_identity_service_with_object_store(
|
|
self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service',
|
|
'object-store']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
|
|
def test_ceph_joined(self):
|
|
relations.ceph_joined()
|
|
self.apt_install.assert_called_with(['ceph-common', 'python-ceph'])
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_missing_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
configs.write = MagicMock()
|
|
relations.ceph_changed()
|
|
self.juju_log.assert_called_with(
|
|
'ceph relation incomplete. Peer not ready?'
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_no_keyring(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['ceph']
|
|
configs.write = MagicMock()
|
|
self.ensure_ceph_keyring.return_value = False
|
|
relations.ceph_changed()
|
|
self.juju_log.assert_called_with(
|
|
'Could not create ceph keyring: peer not ready?'
|
|
)
|
|
|
|
@patch.object(relations, 'get_ceph_request')
|
|
@patch.object(relations, 'send_request_if_needed')
|
|
@patch.object(relations, 'is_request_complete')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_broker_send_rq(self, configs, mock_request_complete,
|
|
mock_send_request_if_needed,
|
|
mock_get_ceph_request):
|
|
self.service_name.return_value = 'glance'
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['ceph']
|
|
mock_get_ceph_request.return_value = 'cephrq'
|
|
self.ensure_ceph_keyring.return_value = True
|
|
mock_request_complete.return_value = False
|
|
relations.hooks.execute(['hooks/ceph-relation-changed'])
|
|
self.ensure_ceph_keyring.assert_called_with(service='glance',
|
|
user='glance',
|
|
group='glance')
|
|
for c in [call('/etc/glance/glance.conf')]:
|
|
self.assertNotIn(c, configs.write.call_args_list)
|
|
|
|
@patch('hooks.charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_request_access_to_group')
|
|
@patch('hooks.charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_create_pool')
|
|
def test_create_pool_op(self, mock_create_pool,
|
|
mock_request_access):
|
|
self.service_name.return_value = 'glance'
|
|
self.test_config.set('ceph-osd-replication-count', 3)
|
|
self.test_config.set('ceph-pool-weight', 6)
|
|
relations.get_ceph_request()
|
|
mock_create_pool.assert_called_with(name='glance', replica_count=3,
|
|
weight=6, group='images')
|
|
mock_request_access.assert_not_called()
|
|
|
|
self.test_config.set('restrict-ceph-pools', True)
|
|
relations.get_ceph_request()
|
|
mock_create_pool.assert_called_with(name='glance', replica_count=3,
|
|
weight=6, group='images')
|
|
mock_request_access.assert_has_calls([
|
|
call(name='images', permission='rwx'),
|
|
])
|
|
|
|
@patch.object(relations, 'get_ceph_request')
|
|
@patch.object(relations, 'send_request_if_needed')
|
|
@patch.object(relations, 'is_request_complete')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_key_and_relation_data(self, configs,
|
|
mock_request_complete,
|
|
mock_send_request_if_needed,
|
|
mock_service):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['ceph']
|
|
configs.write = MagicMock()
|
|
self.ensure_ceph_keyring.return_value = True
|
|
mock_request_complete.return_value = True
|
|
self.ceph_config_file.return_value = '/etc/ceph/ceph.conf'
|
|
relations.ceph_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/ceph/ceph.conf')],
|
|
configs.write.call_args_list)
|
|
self.service_restart.assert_called_with('glance-api')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_broken(self, configs):
|
|
self.service_name.return_value = 'glance'
|
|
relations.ceph_broken()
|
|
self.delete_keyring.assert_called_with(service='glance')
|
|
self.assertTrue(configs.write_all.called)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_keystone_joined(self, _canonical_url):
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.keystone_joined()
|
|
ex = {
|
|
'region': 'RegionOne',
|
|
'public_url': 'http://glancehost:9292',
|
|
'admin_url': 'http://glancehost:9292',
|
|
'service': 'glance',
|
|
'internal_url': 'http://glancehost:9292',
|
|
'relation_id': None,
|
|
}
|
|
self.relation_set.assert_called_with(**ex)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_keystone_joined_with_relation_id(self, _canonical_url):
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.keystone_joined(relation_id='identity-service:0')
|
|
ex = {
|
|
'region': 'RegionOne',
|
|
'public_url': 'http://glancehost:9292',
|
|
'admin_url': 'http://glancehost:9292',
|
|
'service': 'glance',
|
|
'internal_url': 'http://glancehost:9292',
|
|
'relation_id': 'identity-service:0',
|
|
}
|
|
self.relation_set.assert_called_with(**ex)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_keystone_joined_public_endpoint(self, _canonical_url):
|
|
def fake_canonical_url(configs, endpoint_type):
|
|
return {"public": "http://glance.example.com",
|
|
"int": "http://glancehost",
|
|
"admin": "http://glancehost"}[endpoint_type]
|
|
_canonical_url.side_effect = fake_canonical_url
|
|
self.test_config.set('os-public-hostname', 'glance.example.com')
|
|
relations.keystone_joined()
|
|
ex = {
|
|
'region': 'RegionOne',
|
|
'public_url': 'http://glance.example.com:9292',
|
|
'admin_url': 'http://glancehost:9292',
|
|
'service': 'glance',
|
|
'internal_url': 'http://glancehost:9292',
|
|
'relation_id': None,
|
|
}
|
|
self.relation_set.assert_called_with(**ex)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changes_incomplete(self, configs):
|
|
configs.complete_contexts.return_value = []
|
|
relations.keystone_changed()
|
|
self.assertTrue(self.juju_log.called)
|
|
self.assertFalse(configs.write.called)
|
|
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changed_no_object_store_relation(self, configs,
|
|
configure_https):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = []
|
|
relations.keystone_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertTrue(configure_https.called)
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'object_store_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
@patch.object(utils, 'git_install_requested')
|
|
def test_keystone_changed_with_object_store_relation(self, git_requested,
|
|
configs,
|
|
object_store_joined,
|
|
configure_https,
|
|
image_service_joined):
|
|
git_requested.return_value = False
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.side_effect = [
|
|
['object-store:0'],
|
|
['image-service:0'],
|
|
]
|
|
relations.keystone_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
object_store_joined.assert_called_with()
|
|
self.assertTrue(configure_https.called)
|
|
image_service_joined.assert_called_with('image-service:0')
|
|
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'object_store_joined')
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changed_image_service_joined(self, configs, imgsj, osj,
|
|
https):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
|
|
rids = ['nova-cloud-controller:1', 'nova-compute:1']
|
|
self.relation_ids.return_value = rids
|
|
relations.keystone_changed()
|
|
[self.assertIn(call(r), imgsj.call_args_list) for r in rids]
|
|
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'git_install_requested')
|
|
def test_config_changed_no_openstack_upgrade(self, git_requested,
|
|
configure_https):
|
|
git_requested.return_value = False
|
|
self.openstack_upgrade_available.return_value = False
|
|
relations.config_changed()
|
|
self.open_port.assert_called_with(9292)
|
|
self.assertTrue(configure_https.called)
|
|
|
|
@patch.object(relations, 'status_set')
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'git_install_requested')
|
|
def test_config_changed_with_openstack_upgrade(self, git_requested,
|
|
configure_https,
|
|
status):
|
|
git_requested.return_value = False
|
|
self.openstack_upgrade_available.return_value = True
|
|
relations.config_changed()
|
|
status.assert_called_with(
|
|
'maintenance',
|
|
'Upgrading OpenStack release'
|
|
)
|
|
self.assertTrue(self.do_openstack_upgrade.called)
|
|
self.assertTrue(configure_https.called)
|
|
|
|
@patch.object(relations, 'git_install_requested')
|
|
def test_config_changed_with_openstack_upgrade_action(self, git_requested):
|
|
git_requested.return_value = False
|
|
self.openstack_upgrade_available.return_value = True
|
|
self.test_config.set('action-managed-upgrade', True)
|
|
|
|
relations.config_changed()
|
|
self.assertFalse(self.do_openstack_upgrade.called)
|
|
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'git_install_requested')
|
|
@patch.object(relations, 'config_value_changed')
|
|
def test_config_changed_git_updated(self, config_val_changed,
|
|
git_requested, configure_https):
|
|
git_requested.return_value = True
|
|
repo = 'cloud:trusty-juno'
|
|
openstack_origin_git = {
|
|
'repositories': [
|
|
{'name': 'requirements',
|
|
'repository': 'git://git.openstack.org/openstack/requirements', # noqa
|
|
'branch': 'stable/juno'},
|
|
{'name': 'glance',
|
|
'repository': 'git://git.openstack.org/openstack/glance',
|
|
'branch': 'stable/juno'}
|
|
],
|
|
'directory': '/mnt/openstack-git',
|
|
}
|
|
projects_yaml = yaml.dump(openstack_origin_git)
|
|
self.test_config.set('openstack-origin', repo)
|
|
self.test_config.set('openstack-origin-git', projects_yaml)
|
|
relations.config_changed()
|
|
self.git_install.assert_called_with(projects_yaml)
|
|
self.assertFalse(self.do_openstack_upgrade.called)
|
|
self.assertTrue(configure_https.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cluster_changed(self, configs):
|
|
self.test_config.set('prefer-ipv6', False)
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['cluster']
|
|
configs.write = MagicMock()
|
|
relations.cluster_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/haproxy/haproxy.cfg')],
|
|
configs.write.call_args_list)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'relation_set')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cluster_changed_with_ipv6(self, configs, relation_set,
|
|
_canonical_url):
|
|
self.test_config.set('prefer-ipv6', True)
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['cluster']
|
|
configs.write = MagicMock()
|
|
self.get_relation_ip.return_value = '2001:db8:1::1'
|
|
self.relation_ids.return_value = ['cluster:0']
|
|
relations.cluster_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/haproxy/haproxy.cfg')],
|
|
configs.write.call_args_list)
|
|
|
|
@patch.object(utils, 'config')
|
|
@patch.object(utils, 'token_cache_pkgs')
|
|
@patch.object(relations, 'CONFIGS')
|
|
@patch.object(utils, 'git_install_requested')
|
|
def test_upgrade_charm(self, git_requested, configs, token_cache_pkgs,
|
|
util_config):
|
|
git_requested.return_value = False
|
|
self.filter_installed_packages.return_value = ['test']
|
|
relations.upgrade_charm()
|
|
self.apt_install.assert_called_with(['test'], fatal=True)
|
|
self.assertTrue(configs.write_all.called)
|
|
self.assertTrue(self.reinstall_paste_ini.called)
|
|
|
|
def test_ha_relation_joined(self):
|
|
self.get_hacluster_config.return_value = {
|
|
'ha-bindiface': 'em0',
|
|
'ha-mcastport': '8080',
|
|
'vip': '10.10.10.10',
|
|
}
|
|
self.get_iface_for_address.return_value = 'eth1'
|
|
self.get_netmask_for_address.return_value = '255.255.0.0'
|
|
relations.ha_relation_joined()
|
|
args = {
|
|
'relation_id': None,
|
|
'corosync_bindiface': 'em0',
|
|
'corosync_mcastport': '8080',
|
|
'init_services': {'res_glance_haproxy': 'haproxy'},
|
|
'resources': {'res_glance_eth1_vip': 'ocf:heartbeat:IPaddr2',
|
|
'res_glance_haproxy': 'lsb:haproxy'},
|
|
'resource_params': {
|
|
'res_glance_eth1_vip': 'params ip="10.10.10.10"'
|
|
' cidr_netmask="255.255.0.0" nic="eth1"',
|
|
'res_glance_haproxy': 'op monitor interval="5s"'},
|
|
'clones': {'cl_glance_haproxy': 'res_glance_haproxy'}
|
|
}
|
|
self.relation_set.assert_has_calls([
|
|
call(relation_id=None,
|
|
groups={'grp_glance_vips': 'res_glance_eth1_vip'}),
|
|
call(**args),
|
|
])
|
|
|
|
def test_ha_relation_joined_no_bound_ip(self):
|
|
self.get_hacluster_config.return_value = {
|
|
'ha-bindiface': 'em0',
|
|
'ha-mcastport': '8080',
|
|
'vip': '10.10.10.10',
|
|
}
|
|
self.test_config.set('vip_iface', 'eth120')
|
|
self.test_config.set('vip_cidr', '21')
|
|
self.get_iface_for_address.return_value = None
|
|
self.get_netmask_for_address.return_value = None
|
|
relations.ha_relation_joined()
|
|
args = {
|
|
'relation_id': None,
|
|
'corosync_bindiface': 'em0',
|
|
'corosync_mcastport': '8080',
|
|
'init_services': {'res_glance_haproxy': 'haproxy'},
|
|
'resources': {'res_glance_eth120_vip': 'ocf:heartbeat:IPaddr2',
|
|
'res_glance_haproxy': 'lsb:haproxy'},
|
|
'resource_params': {
|
|
'res_glance_eth120_vip': 'params ip="10.10.10.10"'
|
|
' cidr_netmask="21" nic="eth120"',
|
|
'res_glance_haproxy': 'op monitor interval="5s"'},
|
|
'clones': {'cl_glance_haproxy': 'res_glance_haproxy'}
|
|
}
|
|
self.relation_set.assert_has_calls([
|
|
call(relation_id=None,
|
|
groups={'grp_glance_vips': 'res_glance_eth120_vip'}),
|
|
call(**args),
|
|
])
|
|
|
|
def test_ha_relation_joined_with_ipv6(self):
|
|
self.test_config.set('prefer-ipv6', True)
|
|
self.get_hacluster_config.return_value = {
|
|
'ha-bindiface': 'em0',
|
|
'ha-mcastport': '8080',
|
|
'vip': '2001:db8:1::1',
|
|
}
|
|
self.get_iface_for_address.return_value = 'eth1'
|
|
self.get_netmask_for_address.return_value = '64'
|
|
relations.ha_relation_joined()
|
|
args = {
|
|
'relation_id': None,
|
|
'corosync_bindiface': 'em0',
|
|
'corosync_mcastport': '8080',
|
|
'init_services': {'res_glance_haproxy': 'haproxy'},
|
|
'resources': {'res_glance_eth1_vip': 'ocf:heartbeat:IPv6addr',
|
|
'res_glance_haproxy': 'lsb:haproxy'},
|
|
'resource_params': {
|
|
'res_glance_eth1_vip': 'params ipv6addr="2001:db8:1::1"'
|
|
' cidr_netmask="64" nic="eth1"',
|
|
'res_glance_haproxy': 'op monitor interval="5s"'},
|
|
'clones': {'cl_glance_haproxy': 'res_glance_haproxy'}
|
|
}
|
|
self.relation_set.assert_called_with(**args)
|
|
|
|
def test_ha_joined_dns_ha(self):
|
|
def _fake_update(resources, resource_params, relation_id=None):
|
|
resources.update({'res_glance_public_hostname': 'ocf:maas:dns'})
|
|
resource_params.update({'res_glance_public_hostname':
|
|
'params fqdn="keystone.maas" '
|
|
'ip_address="10.0.0.1"'})
|
|
|
|
self.test_config.set('dns-ha', True)
|
|
self.get_hacluster_config.return_value = {
|
|
'vip': None,
|
|
'ha-bindiface': 'em0',
|
|
'ha-mcastport': '8080',
|
|
'os-admin-hostname': None,
|
|
'os-internal-hostname': None,
|
|
'os-public-hostname': 'keystone.maas',
|
|
}
|
|
args = {
|
|
'relation_id': None,
|
|
'corosync_bindiface': 'em0',
|
|
'corosync_mcastport': '8080',
|
|
'init_services': {'res_glance_haproxy': 'haproxy'},
|
|
'resources': {'res_glance_public_hostname': 'ocf:maas:dns',
|
|
'res_glance_haproxy': 'lsb:haproxy'},
|
|
'resource_params': {
|
|
'res_glance_public_hostname': 'params fqdn="keystone.maas" '
|
|
'ip_address="10.0.0.1"',
|
|
'res_glance_haproxy': 'op monitor interval="5s"'},
|
|
'clones': {'cl_glance_haproxy': 'res_glance_haproxy'}
|
|
}
|
|
self.update_dns_ha_resource_params.side_effect = _fake_update
|
|
|
|
relations.ha_relation_joined()
|
|
self.assertTrue(self.update_dns_ha_resource_params.called)
|
|
self.relation_set.assert_called_with(**args)
|
|
|
|
def test_ha_relation_changed_not_clustered(self):
|
|
self.relation_get.return_value = False
|
|
relations.ha_relation_changed()
|
|
self.juju_log.assert_called_with(
|
|
'ha_changed: hacluster subordinate is not fully clustered.'
|
|
)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'keystone_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_enable_with_identity_service(
|
|
self, configs, keystone_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['https']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['identity-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2ensite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
keystone_joined.assert_called_with(relation_id='identity-service:0')
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'keystone_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_disable_with_keystone_joined(
|
|
self, configs, keystone_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['identity-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2dissite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
keystone_joined.assert_called_with(relation_id='identity-service:0')
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_enable_with_image_service(
|
|
self, configs, image_service_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['https']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['image-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2ensite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
image_service_joined.assert_called_with(relation_id='image-service:0')
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_disable_with_image_service(
|
|
self, configs, image_service_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['image-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2dissite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
image_service_joined.assert_called_with(relation_id='image-service:0')
|
|
|
|
def test_amqp_joined(self):
|
|
relations.amqp_joined()
|
|
self.relation_set.assert_called_with(
|
|
username='glance',
|
|
vhost='openstack')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_amqp_changed_missing_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
relations.amqp_changed()
|
|
self.assertTrue(self.juju_log.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_amqp_changed_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['amqp']
|
|
configs.write = MagicMock()
|
|
relations.amqp_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertFalse(self.juju_log.called)
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'keystone_joined')
|
|
def test_ha_relation_changed(self, ks_joined, image_joined):
|
|
self.relation_get.return_value = True
|
|
self.relation_ids.side_effect = [['identity:0'], ['image:1']]
|
|
relations.ha_relation_changed()
|
|
ks_joined.assert_called_with('identity:0')
|
|
image_joined.assert_called_with('image:1')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_relation_broken(self, configs):
|
|
relations.relation_broken()
|
|
self.assertTrue(configs.write_all.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cinder_volume_joined(self, configs):
|
|
self.filter_installed_packages.side_effect = lambda pkgs: pkgs
|
|
relations.cinder_volume_service_relation_joined()
|
|
self.assertTrue(configs.write_all.called)
|
|
self.apt_install.assert_called_with(
|
|
["python-cinderclient",
|
|
"python-os-brick",
|
|
"python-oslo.rootwrap"], fatal=True
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_storage_backend_changed(self, configs):
|
|
self.filter_installed_packages.side_effect = lambda pkgs: pkgs
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['storage-backend']
|
|
configs.write = MagicMock()
|
|
relations.storage_backend_hook()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.apt_install.assert_called_with(
|
|
["python-cinderclient",
|
|
"python-os-brick",
|
|
"python-oslo.rootwrap"], fatal=True
|
|
)
|