From 0a2315c19678a22cff7099626359ad8fb032dad0 Mon Sep 17 00:00:00 2001
From: David Ames <david.ames@canonical.com>
Date: Wed, 16 May 2018 14:31:14 -0700
Subject: [PATCH] Enable Bionic as a gate test

Change bionic test from dev to gate for 18.05.

Change-Id: Ib4cf1f94b3ba86380f79b5254e21de46f23d3c98
---
 .gitignore                          | 1 +
 src/tests/basic_deployment.py       | 7 +++++--
 src/tox.ini                         | 2 +-
 unit_tests/__init__.py              | 4 ++++
 unit_tests/test_gnocchi_handlers.py | 3 ++-
 5 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/.gitignore b/.gitignore
index 158771a..48489cc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@ func-results.json
 test-charm/
 .project
 .pydevproject
+*.pyc
 **/__pycache__
 interfaces
 layers
diff --git a/src/tests/basic_deployment.py b/src/tests/basic_deployment.py
index b1fe98e..ac59afa 100644
--- a/src/tests/basic_deployment.py
+++ b/src/tests/basic_deployment.py
@@ -62,7 +62,6 @@ class GnocchiCharmDeployment(amulet_deployment.OpenStackAmuletDeployment):
         this_service = {'name': 'gnocchi'}
         other_services = [
             {'name': 'percona-cluster'},
-            {'name': 'mongodb'},
             {'name': 'ceilometer'},
             {'name': 'keystone'},
             {'name': 'rabbitmq-server'},
@@ -70,6 +69,10 @@ class GnocchiCharmDeployment(amulet_deployment.OpenStackAmuletDeployment):
             {'name': 'ceph-mon', 'units': 3},
             {'name': 'ceph-osd', 'units': 3},
         ]
+
+        if self._get_openstack_release() < self.xenial_queens:
+            other_services.append({'name': 'mongodb'})
+
         super(GnocchiCharmDeployment, self)._add_services(
             this_service,
             other_services,
@@ -85,7 +88,6 @@ class GnocchiCharmDeployment(amulet_deployment.OpenStackAmuletDeployment):
             'gnocchi:storage-ceph': 'ceph-mon:client',
             'gnocchi:metric-service': 'ceilometer:metric-service',
             'gnocchi:coordinator-memcached': 'memcached:cache',
-            'ceilometer:shared-db': 'mongodb:database',
             'ceilometer:amqp': 'rabbitmq-server:amqp',
             'ceph-mon:osd': 'ceph-osd:mon',
         }
@@ -95,6 +97,7 @@ class GnocchiCharmDeployment(amulet_deployment.OpenStackAmuletDeployment):
         else:
             relations['ceilometer:identity-service'] = \
                 'keystone:identity-service'
+            relations['ceilometer:shared-db'] = 'mongodb:database'
         super(GnocchiCharmDeployment, self)._add_relations(relations)
 
     def _configure_services(self):
diff --git a/src/tox.ini b/src/tox.ini
index f498279..4dcbb6f 100644
--- a/src/tox.ini
+++ b/src/tox.ini
@@ -35,7 +35,7 @@ commands =
 # Run a specific test as an Amulet smoke test (expected to always pass)
 basepython = python2.7
 commands =
-    bundletester -vl DEBUG -r json -o func-results.json gate-basic-xenial-queens --no-destroy
+    bundletester -vl DEBUG -r json -o func-results.json gate-basic-bionic-queens --no-destroy
 
 [testenv:func27-dfs]
 # Run all deploy-from-source tests which are +x (may not always pass!)
diff --git a/unit_tests/__init__.py b/unit_tests/__init__.py
index cb6010f..d788775 100644
--- a/unit_tests/__init__.py
+++ b/unit_tests/__init__.py
@@ -24,6 +24,10 @@ charms_openstack.test_mocks.mock_charmhelpers()
 
 def mock_more_stuff():
     charmhelpers = charms_openstack.test_mocks.charmhelpers
+    sys.modules['charmhelpers.core.hookenv.charm_dir'] = (
+        charmhelpers.core.hookenv.charm_dir
+    )
+    charmhelpers.core.hookenv.charm_dir.return_value = "/tmp"
     sys.modules['charmhelpers.contrib.storage'] = (
         charmhelpers.contrib.storage
     )
diff --git a/unit_tests/test_gnocchi_handlers.py b/unit_tests/test_gnocchi_handlers.py
index a071137..9eaf33b 100644
--- a/unit_tests/test_gnocchi_handlers.py
+++ b/unit_tests/test_gnocchi_handlers.py
@@ -114,9 +114,10 @@ class TestHandlers(test_utils.PatchHelper):
             'mygnocchi',
         )
 
+    @mock.patch.object(handlers, 'os')
     @mock.patch.object(handlers, 'hookenv')
     @mock.patch.object(handlers, 'ceph_helper')
-    def test_configure_ceph(self, mock_ceph_helper, mock_hookenv):
+    def test_configure_ceph(self, mock_ceph_helper, mock_hookenv, mock_os):
         mock_ceph = mock.MagicMock()
         mock_ceph.key.return_value = 'testkey'
         mock_hookenv.service_name.return_value = 'gnocchi'