Update patch set 5
Patch Set 5: Code-Review-1 (5 comments) Patch-set: 5 Reviewer: Gerrit User 1131 <1131@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 6b6f6c94bb57fbf2a2de811bad6dac7cb0c23118
This commit is contained in:
parent
1ea840173c
commit
248ba36ecf
|
@ -16,6 +16,121 @@
|
|||
"message": "LGTM",
|
||||
"revId": "8d44eaf08242cd09f13ed0abc01c41aa51fdf70a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9f9800f8_f1a44049",
|
||||
"filename": "doc/source/project/procedures/cinder-lvm-tgt-to-lio-migration.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 15,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2024-03-21T18:14:49Z",
|
||||
"side": 1,
|
||||
"message": "I think you don\u0027t typically but numbers, but use \u0027#\u0027 and let the tools auto-number, for example:\n\n#. Upgrade cinder ...",
|
||||
"range": {
|
||||
"startLine": 15,
|
||||
"startChar": 0,
|
||||
"endLine": 15,
|
||||
"endChar": 3
|
||||
},
|
||||
"revId": "8d44eaf08242cd09f13ed0abc01c41aa51fdf70a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f37ed9d8_405cdb06",
|
||||
"filename": "doc/source/project/procedures/cinder-lvm-tgt-to-lio-migration.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 20,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2024-03-21T18:14:49Z",
|
||||
"side": 1,
|
||||
"message": "s/from the Wallaby channel",
|
||||
"range": {
|
||||
"startLine": 20,
|
||||
"startChar": 19,
|
||||
"endLine": 20,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "8d44eaf08242cd09f13ed0abc01c41aa51fdf70a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e5c32064_71b2011f",
|
||||
"filename": "doc/source/project/procedures/cinder-lvm-tgt-to-lio-migration.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2024-03-21T18:14:49Z",
|
||||
"side": 1,
|
||||
"message": "s/upgrade,",
|
||||
"range": {
|
||||
"startLine": 23,
|
||||
"startChar": 26,
|
||||
"endLine": 23,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "8d44eaf08242cd09f13ed0abc01c41aa51fdf70a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6f1e81d5_e63b3d1e",
|
||||
"filename": "doc/source/project/procedures/cinder-lvm-tgt-to-lio-migration.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 39,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2024-03-21T18:14:49Z",
|
||||
"side": 1,
|
||||
"message": "Recommended or required? Will it work if not given?",
|
||||
"range": {
|
||||
"startLine": 39,
|
||||
"startChar": 34,
|
||||
"endLine": 39,
|
||||
"endChar": 45
|
||||
},
|
||||
"revId": "8d44eaf08242cd09f13ed0abc01c41aa51fdf70a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c0a1bf84_13677bcb",
|
||||
"filename": "doc/source/project/procedures/cinder-lvm-tgt-to-lio-migration.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 61,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2024-03-21T18:14:49Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t see where this was created, or is it output?",
|
||||
"range": {
|
||||
"startLine": 61,
|
||||
"startChar": 48,
|
||||
"endLine": 61,
|
||||
"endChar": 67
|
||||
},
|
||||
"revId": "8d44eaf08242cd09f13ed0abc01c41aa51fdf70a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue