openstack
/
charm-guide
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 30561 <30561@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 82240a3b62e7e651a68589bc0e615fc57d011dc9
Attention: {"person_ident":"Gerrit User 36966 \u003c36966@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30561\u003e replied on the change"}
This commit is contained in:
Gerrit User 30561 2024-04-29 15:27:46 +00:00 committed by Gerrit Code Review
parent 2fe204642b
commit d339a7011f
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
7044df3f285e7a43c8a29ad583e456d2320ff8c3 Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a8a2fb89_ab539e57",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 30561
},
"writtenOn": "2024-04-29T15:27:46Z",
"side": 1,
"message": "Thanks a lot for this Myles.\n\nI\u0027ve mentioned some minor items to fix.",
"revId": "7044df3f285e7a43c8a29ad583e456d2320ff8c3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "887e11ca_05567fb4",
"filename": "doc/source/release-notes/2024.1-caracal.rst",
"patchSetId": 1
},
"lineNbr": 60,
"author": {
"id": 30561
},
"writtenOn": "2024-04-29T15:27:46Z",
"side": 1,
"message": "we capitalise upstream project names (but keep our charms lowercase). so this should be \"Keystone\"",
"range": {
"startLine": 60,
"startChar": 30,
"endLine": 60,
"endChar": 31
},
"revId": "7044df3f285e7a43c8a29ad583e456d2320ff8c3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "280e1a14_5356edc0",
"filename": "doc/source/release-notes/2024.1-caracal.rst",
"patchSetId": 1
},
"lineNbr": 64,
"author": {
"id": 30561
},
"writtenOn": "2024-04-29T15:27:46Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 64,
"startChar": 20,
"endLine": 64,
"endChar": 21
},
"revId": "7044df3f285e7a43c8a29ad583e456d2320ff8c3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e7fa258a_c4dfbea0",
"filename": "doc/source/release-notes/2024.1-caracal.rst",
"patchSetId": 1
},
"lineNbr": 66,
"author": {
"id": 30561
},
"writtenOn": "2024-04-29T15:27:46Z",
"side": 1,
"message": "wayward space",
"range": {
"startLine": 66,
"startChar": 69,
"endLine": 66,
"endChar": 70
},
"revId": "7044df3f285e7a43c8a29ad583e456d2320ff8c3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}