charm-hacluster/6861f847c62ca7fff4339f75bff572e2ccb2b948

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "32df0bd3_832c57af",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 20870
      },
      "writtenOn": "2021-11-17T16:10:31Z",
      "side": 1,
      "message": "I think that this contains two patches, but please correct me if I\u0027m wrong.  There is a refactor that moves code out of hooks.py and into utils.py, and a separate piece of code that adds running the config-changed checking code after upgrade charm.\n\nIf this *is* the case, then the config-changed checking bit (which is the bug fix) is lost amongst the refactor.  I think this should be split across two stacked patches so that we can see a no-behaviour change refactor and then the actual bug fix.  Is this okay?",
      "revId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "6b0bdec3_53434188",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2021-11-22T21:16:41Z",
      "side": 1,
      "message": "config-changed is invoking the moved code (that was previously ha-relation-changed) through assess_status_helper. Upgrade-charm invokes assess_status_helper as well.\n\nDespite the LP description stating that upgrade-charm should run config-changed, I have not seen any value for that so far for this use case. If upgrade-charm invokes config-changed, there is no need for it to invoke assess_status_helper.",
      "parentUuid": "32df0bd3_832c57af",
      "revId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "72fa1be1_2b1d43b8",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2021-11-22T21:16:41Z",
      "side": 1,
      "message": "Thanks for the preliminary review Alex, more work in pending in this patch.",
      "revId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "81096e86_5a09c5b5",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-01-05T18:20:43Z",
      "side": 1,
      "message": "this is still a very nice improvement to have, but we do not currently have a meaningful demand or motivation for further working on it at the moment. Abandoning it. This was worked in conjunction with https://review.opendev.org/c/openstack/charm-hacluster/+/818996",
      "revId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d998afa0_801bbe8e",
        "filename": "unit_tests/test_hacluster_hooks.py",
        "patchSetId": 2
      },
      "lineNbr": 45,
      "author": {
        "id": 20870
      },
      "writtenOn": "2021-11-17T16:10:31Z",
      "side": 1,
      "message": "Note that this file is called \"test_hacluster_hooks.py\", and this is (now) testing code in a different .py file.  These tests should be moved to the relevant test file, please.",
      "range": {
        "startLine": 45,
        "startChar": 0,
        "endLine": 45,
        "endChar": 44
      },
      "revId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "880e297d_638b9139",
        "filename": "unit_tests/test_hacluster_hooks.py",
        "patchSetId": 2
      },
      "lineNbr": 45,
      "author": {
        "id": 14567
      },
      "writtenOn": "2021-11-22T21:16:41Z",
      "side": 1,
      "message": "yep this is pending, along with some extra unit tests.",
      "parentUuid": "d998afa0_801bbe8e",
      "range": {
        "startLine": 45,
        "startChar": 0,
        "endLine": 45,
        "endChar": 44
      },
      "revId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ],
  "submitRequirementResults": [
    {
      "submitRequirement": {
        "name": "Backport-Candidate",
        "description": {
          "value": "Backport candidate status"
        },
        "applicabilityExpression": {
          "value": {
            "expressionString": "is:false"
          }
        },
        "submittabilityExpression": {
          "expressionString": "is:true"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {
        "value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
      },
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Code-Review",
        "description": {
          "value": "Code reviewed by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": true
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Verified",
        "description": {
          "value": "Verified in gate by CI"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Workflow",
        "description": {
          "value": "Approved for gate by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Workflow=MAX","label:Workflow=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "6861f847c62ca7fff4339f75bff572e2ccb2b948",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    }
  ]
}