Update patch set 2

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2

f6f48edf9ee36952fd25955fc5d0a4bb4067cc8e

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3f65232a_326ab5b2",
+        "filename": "requires.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 238,
+      "author": {
+        "id": 13178
+      },
+      "writtenOn": "2020-10-27T14:40:04Z",
+      "side": 1,
+      "message": "I included this patch in the implementation work for the Cinder Ceph replication spec, and I have some feedback.\n\nI don\u0027t think that we need to yield JSON object here. I believe that we need to yield `ch_ceph.CephBrokerRq(raw_request_data\u003djson_rq)`.\n\nI patched the `ceph-rbd-mirror` interface with the update from here, and I also updated the `ceph-rbd-mirror` charm handlers to properly forward the broker request to the remote Ceph via the above `maybe_send_rq` method: https://github.com/ionutbalutoiu/charm-ceph-rbd-mirror/commit/b2de2f6eb0d36db28be20b37957c495ccda42a68#diff-5d6afa6e630f1f38257166003cc63cbb2e2dff926e6e1887eccea5111e4daafcR101. \n\nIf we yield JSON object, I\u0027m getting the error: https://paste.ubuntu.com/p/qdmBCdQcBq.\n\nThis happens, because `ch_ceph.send_request_if_needed(rq, relation\u003dself.endpoint_name)` from above expects a `CephBrokerRq` parameter, and we\u0027ll be sending a JSON object.\n\nIf we yield `CephBrokerRq` objects here instead of simple JSON objects, everything is fine.",
+      "revId": "f6f48edf9ee36952fd25955fc5d0a4bb4067cc8e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}