Update patch set 1

Patch Set 1: Code-Review-1

(1 comment)

LGTM in general, thanks!

Patch-set: 1
Reviewer: Gerrit User 31289 <31289@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 31289 2021-09-21 09:24:03 +00:00 committed by Gerrit Code Review
parent af3c6c6a62
commit 2596e9e041
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "7e711f6c_dcdaa454",
"filename": "interface_hacluster/ops_ha_interface.py",
"patchSetId": 1
},
"lineNbr": 76,
"author": {
"id": 31289
},
"writtenOn": "2021-09-21T09:24:03Z",
"side": 1,
"message": "I see this method isn\u0027t called anywhere here so I believe this is supposed to be called by the requirer charm, i.e. the principal charm? Also I have difficulties to understand when the charm is supposed to call this. Which kind of data are we dealing with here? If I had to implement a brand new charm implementing this side of the relation, I wouldn\u0027t know when to call this method. Should we add a docstring explaining what this method does and when to call it?",
"revId": "609977b5691a3afb3ab3f96ac7609a8331d8f812",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}