openstack
/
charm-interface-hacluster
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2 Workflow+1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 2424 <2424@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 821463990f21e702a8accc159da803fabf1f7fcd
Label: Workflow=+1, 57c1e30aa6d79a493fa34d73297faae8a7858168
This commit is contained in:
Gerrit User 2424 2023-11-28 19:03:28 +00:00 committed by Gerrit Code Review
parent d8457d8204
commit 48dfc9a463
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
d91e83a1fa59a13f4160febfe536c68dc762e436
View File

@ -16,6 +16,23 @@
"message": "Good Catch! Looks good to me.",
"revId": "d91e83a1fa59a13f4160febfe536c68dc762e436",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d69cc80c_69531a0c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 2424
},
"writtenOn": "2023-11-28T19:03:28Z",
"side": 1,
"message": "this seems to have been introduced by this change - https://opendev.org/openstack/charm-interface-hacluster/commit/679a76dfe564ab1a8f46a124f2f8b74ba3e96965#diff-bffcf9cc8717200367943944593d2ca630efc604 , I think makes sense to use the arguments passed to the method instead of relying on a property set by a child, specially in a multi-inheritance scenario like this one.",
"revId": "d91e83a1fa59a13f4160febfe536c68dc762e436",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}