openstack
/
charm-keystone
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2

(1 comment)

Patch-set: 3
CC: Gerrit User 935 <935@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 25de365be6b1c5c7cc77c7c65e6d4e8f67abd187
Attention: {"person_ident":"Gerrit User 14567 \u003c14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_20870\u003e replied on the change"}
This commit is contained in:
Gerrit User 20870 2024-03-25 15:56:51 +00:00 committed by Gerrit Code Review
parent 3308c6021e
commit ea9a47d33e
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
0967f6ec4eacf69a5cee9b7582daed973e1dded4
View File

@ -33,6 +33,23 @@
"message": "@Alex, yes, this is the easiest approach. We have already spent development time twice investigating more robust and complex approaches in the past (see below). We keep hitting this issue over and over and need to have a fix.\n\nhttps://review.opendev.org/c/openstack/charm-keystone/+/777197\nhttps://review.opendev.org/c/openstack/charms.openstack/+/841792",
"revId": "0967f6ec4eacf69a5cee9b7582daed973e1dded4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "89324b76_3204277b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 20870
},
"writtenOn": "2024-03-25T15:56:51Z",
"side": 1,
"message": "Okay, I\u0027m switching to a +2, but I\u0027d also like James to have a final once over on it as a verification.",
"revId": "0967f6ec4eacf69a5cee9b7582daed973e1dded4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}