openstack
/
charm-nova-compute
Code Issues Proposed changes

Improve platform mocking 

Patch out charmhelpers.osplatform.get_platform() and
charmhelpers.core.host.lsb_release() globally in the unit tests to
insulate the unit tests from the platform that the unit tests are being
run on.

Change-Id: I33d473d83a7c8f4f23840b6b6bcf153ed423ccdc
This commit is contained in:
Alex Kavanagh 2023-10-24 12:33:41 +01:00
parent e70f228916
commit d90d6ee847
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
unit_tests/__init__.py
View File

@ -13,7 +13,7 @@
# limitations under the License.
import sys
from unittest.mock import MagicMock
from unittest.mock import MagicMock, patch
# python-apt is not installed as part of test-requirements but is imported by
# some charmhelpers modules so create a fake import.
@ -23,3 +23,15 @@ sys.modules['apt_pkg'] = MagicMock()
sys.path.append('actions/')
sys.path.append('hooks/')
sys.path.append('unit_tests')
# Patch out lsb_release() and get_platform() as unit tests should be fully
# insulated from the underlying platform. Unit tests assume that the system is
# ubuntu jammy.
patch(
'charmhelpers.osplatform.get_platform', return_value='ubuntu'
).start()
patch(
'charmhelpers.core.host.lsb_release',
return_value={
'DISTRIB_CODENAME': 'jammy'
}).start()