From 265f0c4847cb1fe7932a458e462e93983f46009d Mon Sep 17 00:00:00 2001 From: Gerrit User 8992 <8992@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 28 Mar 2024 01:30:13 +0000 Subject: [PATCH] Update patch set 5 Patch Set 5: Code-Review-1 (2 comments) Patch-set: 5 Reviewer: Gerrit User 8992 <8992@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 9d75639605c06dd5b6bdc639ef394a25e9a58afd --- f9cc25307e2db2819844951617201c758b3c86f3 | 34 ++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/f9cc25307e2db2819844951617201c758b3c86f3 b/f9cc25307e2db2819844951617201c758b3c86f3 index 4c75ec3a..e287efec 100644 --- a/f9cc25307e2db2819844951617201c758b3c86f3 +++ b/f9cc25307e2db2819844951617201c758b3c86f3 @@ -16,6 +16,40 @@ "message": "LGTM", "revId": "f9cc25307e2db2819844951617201c758b3c86f3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "cc192ef1_e4e593df", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 5 + }, + "lineNbr": 0, + "author": { + "id": 8992 + }, + "writtenOn": "2024-03-28T01:30:13Z", + "side": 1, + "message": "small comment regarding the name of the option, but otherwise looks good", + "revId": "f9cc25307e2db2819844951617201c758b3c86f3", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1673f319_650fa1d2", + "filename": "config.yaml", + "patchSetId": 5 + }, + "lineNbr": 532, + "author": { + "id": 8992 + }, + "writtenOn": "2024-03-28T01:30:13Z", + "side": 1, + "message": "Can we shorten the option name to something like totp-enabled or mfa-totp-enabled? The openstack-keystone prefix makes this option a bit long.", + "revId": "f9cc25307e2db2819844951617201c758b3c86f3", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file