openstack
/
charm-trove
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Really nice piece of work to bring it up to date with charms.openstack!

Just one missed keystone version that Dmitrii didn't spot to add.

Thanks.

Patch-set: 1
Reviewer: Gerrit User 20870 <20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 20870 2017-03-08 17:02:05 +00:00 committed by Gerrit Code Review
parent 3cf5e5fba7
commit 6fc60cf0db
1 changed files with 64 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
f39508b63f40edbb12c09bdf0740564814efae9a
View File

@ -92,6 +92,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a30ddce_cb394943",
"filename": "src/templates/mitaka/trove-taskmanager.conf",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 20870
},
"writtenOn": "2017-03-08T17:02:05Z",
"side": 1,
"message": "You could also just do:\n\n {% if options.default_neutron-networks %}",
"parentUuid": "9a30ddce_92aa5ed3",
"range": {
"startLine": 15,
"startChar": 42,
"endLine": 15,
"endChar": 48
},
"revId": "f39508b63f40edbb12c09bdf0740564814efae9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a30ddce_17f02090",
@ -184,6 +208,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a30ddce_6b613d39",
"filename": "src/templates/newton/trove-taskmanager.conf",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 20870
},
"writtenOn": "2017-03-08T17:02:05Z",
"side": 1,
"message": "As per Dmitrii\u0027s other comments on Keystone version numbers",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 21,
"endChar": 162
},
"revId": "f39508b63f40edbb12c09bdf0740564814efae9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a30ddce_52bf06d0",
@ -206,6 +253,23 @@
"revId": "f39508b63f40edbb12c09bdf0740564814efae9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a30ddce_8b64b149",
"filename": "src/templates/newton/trove.conf",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 20870
},
"writtenOn": "2017-03-08T17:02:05Z",
"side": 1,
"message": "nit: whitespace.",
"revId": "f39508b63f40edbb12c09bdf0740564814efae9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}