openstack
/
charm-trove
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Looking at the commit message guide now

Patch-set: 4
Reviewer: Gerrit User 25341 <25341@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 25341 2017-03-30 15:58:21 +00:00 committed by Gerrit Code Review
parent 2949e9342b
commit f8463ea547
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
e91c5384566cb849039f5eae1fa34ce65cb27c7b
View File

@ -34,6 +34,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffe62b97_bf04c57f",
"filename": "src/lib/charm/openstack/trove.py",
"patchSetId": 4
},
"lineNbr": 209,
"author": {
"id": 25341
},
"writtenOn": "2017-03-30T15:58:21Z",
"side": 1,
"message": "It\u0027s required to use the default amqp.connected hook:\nhttps://github.com/openstack/charms.openstack/blob/master/charms_openstack/charm.py#L181",
"parentUuid": "ffe62b97_fe8181c4",
"revId": "e91c5384566cb849039f5eae1fa34ce65cb27c7b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffe62b97_de847dd5",
@ -50,6 +68,24 @@
"revId": "e91c5384566cb849039f5eae1fa34ce65cb27c7b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffe62b97_1f23b107",
"filename": "src/lib/charm/openstack/trove.py",
"patchSetId": 4
},
"lineNbr": 216,
"author": {
"id": 25341
},
"writtenOn": "2017-03-30T15:58:21Z",
"side": 1,
"message": "It\u0027s required to use the default shared-db.connected hook: https://github.com/openstack/charms.openstack/blob/master/charms_openstack/charm.py#L197",
"parentUuid": "ffe62b97_de847dd5",
"revId": "e91c5384566cb849039f5eae1fa34ce65cb27c7b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}