openstack
/
charms.ceph
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(5 comments)

Thanks for review.

Patch-set: 9
This commit is contained in:
Gerrit User 32363 2021-07-22 07:58:21 +00:00 committed by Gerrit Code Review
parent acd8dc3635
commit 950831bd96
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b520cd3d_bcab8aaf",
"filename": "charms_ceph/utils.py",
"patchSetId": 7
},
"lineNbr": 578,
"author": {
"id": 32363
},
"writtenOn": "2021-07-22T07:58:21Z",
"side": 1,
"message": "I like the `_filter_nodes_and_set_attributes` name more.",
"parentUuid": "bea80de4_8a088fa4",
"revId": "f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "0f323654_fd3f1dec",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "a834d84b_5a35a8bb",
"filename": "charms_ceph/utils.py",
"patchSetId": 7
},
"lineNbr": 579,
"author": {
"id": 32363
},
"writtenOn": "2021-07-22T07:58:21Z",
"side": 1,
"message": "Done",
"parentUuid": "0f323654_fd3f1dec",
"revId": "f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "60336a9b_03219859",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "f68181a5_44771177",
"filename": "charms_ceph/utils.py",
"patchSetId": 7
},
"lineNbr": 598,
"author": {
"id": 32363
},
"writtenOn": "2021-07-22T07:58:21Z",
"side": 1,
"message": "Done",
"parentUuid": "60336a9b_03219859",
"revId": "f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "a1e88fea_d7806c27",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "1ea0311c_6221dc56",
"filename": "charms_ceph/utils.py",
"patchSetId": 7
},
"lineNbr": 600,
"author": {
"id": 32363
},
"writtenOn": "2021-07-22T07:58:21Z",
"side": 1,
"message": "Done",
"parentUuid": "a1e88fea_d7806c27",
"revId": "f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "0fadd7d0_d7959321",
@ -84,6 +156,24 @@
"revId": "f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "97d96430_1a444439",
"filename": "charms_ceph/utils.py",
"patchSetId": 7
},
"lineNbr": 604,
"author": {
"id": 32363
},
"writtenOn": "2021-07-22T07:58:21Z",
"side": 1,
"message": "Done",
"parentUuid": "0fadd7d0_d7959321",
"revId": "f5741d8e4f2dc81fb2cb732faa09774e0d9caaa8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}