openstack
/
charms.openstack
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
This commit is contained in:
Gerrit User 6737 2024-05-01 12:05:47 +00:00 committed by Gerrit Code Review
parent 39bd3de4d0
commit 1cd23528cf
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
981bcac22b6b9dbda7ca4c604c687227ad23bae0
View File

@ -151,6 +151,30 @@
"revId": "981bcac22b6b9dbda7ca4c604c687227ad23bae0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b8e92b4e_332d0c4e",
"filename": "charms_openstack/charm/core.py",
"patchSetId": 4
},
"lineNbr": 1178,
"author": {
"id": 6737
},
"writtenOn": "2024-05-01T12:05:47Z",
"side": 1,
"message": "Could use list of tuples, the key really is to maintain order and the above is a quick way to do that and also keeps the type consistent with what pass passed in. I can convert to list of tuples if necessary.",
"parentUuid": "eaaa5760_b8fe9334",
"range": {
"startLine": 1177,
"startChar": 0,
"endLine": 1178,
"endChar": 40
},
"revId": "981bcac22b6b9dbda7ca4c604c687227ad23bae0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {