openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
CC: Gerrit User 28271 <28271@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 28271 2024-03-27 11:59:20 +00:00 committed by Gerrit Code Review
parent 90dd21e516
commit 2b094d56ac
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
3bb1050ac0e96c85213e3a7e807bf826020fc6c6 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "990b2f74_daafefbb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 28271
},
"writtenOn": "2024-03-27T11:59:20Z",
"side": 1,
"message": "It would be nice, if you rebase your change, put the spec in the new targeted folder for 2024.2 and solve the tox-docs Error.",
"revId": "3bb1050ac0e96c85213e3a7e807bf826020fc6c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "00d074d9_d61f2a9e",
"filename": "specs/untargeted/byok-for-cinder.rst",
"patchSetId": 1
},
"lineNbr": 31,
"author": {
"id": 28271
},
"writtenOn": "2024-03-27T11:59:20Z",
"side": 1,
"message": "nit: \"pieces\"",
"revId": "3bb1050ac0e96c85213e3a7e807bf826020fc6c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "da9c400f_823fd9dc",
"filename": "specs/untargeted/byok-for-cinder.rst",
"patchSetId": 1
},
"lineNbr": 53,
"author": {
"id": 28271
},
"writtenOn": "2024-03-27T11:59:20Z",
"side": 1,
"message": "This should also include a check, whether the provided or default volume type has an encryption type.\n\nMaybe an addition of a default encryption volume type as a config parameter would be nice, as users might forget to provide a correct volume type.\n\nThis would also result in an impyct for deployers as they will have to fill such a config parameter.",
"revId": "3bb1050ac0e96c85213e3a7e807bf826020fc6c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}