openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(5 comments)

Patch-set: 4
Reviewer: Gerrit User 5314 <5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, fbb0279ad5c7f4d0a26d447c2ee2f066cf5bef0a
Attention: {"person_ident":"Gerrit User 5314 \u003c5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_5314\u003e replied on the change"}
This commit is contained in:
Gerrit User 5314 2023-06-09 20:27:01 +00:00 committed by Gerrit Code Review
parent e1e3f33997
commit 3663e67e1f
1 changed files with 101 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

101
466087ef3fe4d8d7ef26a2b2abfda319604a1b04 Normal file
View File

@ -0,0 +1,101 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d5614002_28c81498",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:27:01Z",
"side": 1,
"message": "A few questions inline.",
"revId": "466087ef3fe4d8d7ef26a2b2abfda319604a1b04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e1d2d87c_ced6fc39",
"filename": "specs/untargeted/sizing-capacity-rounded-volumes.rst",
"patchSetId": 4
},
"lineNbr": 23,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:27:01Z",
"side": 1,
"message": "within",
"range": {
"startLine": 23,
"startChar": 22,
"endLine": 23,
"endChar": 29
},
"revId": "466087ef3fe4d8d7ef26a2b2abfda319604a1b04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c3e99adb_c9f0b0ff",
"filename": "specs/untargeted/sizing-capacity-rounded-volumes.rst",
"patchSetId": 4
},
"lineNbr": 39,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:27:01Z",
"side": 1,
"message": "How will this be communicated back to cinder?",
"revId": "466087ef3fe4d8d7ef26a2b2abfda319604a1b04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9286aae9_e4a1a7d2",
"filename": "specs/untargeted/sizing-capacity-rounded-volumes.rst",
"patchSetId": 4
},
"lineNbr": 46,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:27:01Z",
"side": 1,
"message": "I think what you want to say here is that the allocated_size will only be returned in appropriate API responses when the API call is being made by an administrator (because they may need to use it for capacity computations or something).",
"range": {
"startLine": 45,
"startChar": 2,
"endLine": 46,
"endChar": 48
},
"revId": "466087ef3fe4d8d7ef26a2b2abfda319604a1b04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "82db4366_2b3d56d1",
"filename": "specs/untargeted/sizing-capacity-rounded-volumes.rst",
"patchSetId": 4
},
"lineNbr": 57,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:27:01Z",
"side": 1,
"message": "How is os-brick going to know that it needs to do this?",
"revId": "466087ef3fe4d8d7ef26a2b2abfda319604a1b04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}