Update patch set 9
Patch Set 9: (9 comments) Patch-set: 9
This commit is contained in:
Gerrit User 34859
Gerrit Code Review
parent
00f44fa4a3
commit
6cff1a5153
|
|
@ -40,6 +40,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0b0eba5b_bd9e7a97",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 37,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "7e5a59ab_da531c89",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 0,
|
||||
"endLine": 37,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -134,6 +158,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ae968667_7e9dd72f",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 69,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "I reworded it like this now.\nIs this okay, or do I need to be more specific?",
|
||||
"parentUuid": "203aac91_4683e54e",
|
||||
"range": {
|
||||
"startLine": 69,
|
||||
"startChar": 0,
|
||||
"endLine": 69,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -204,6 +252,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e500af7b_c7ebfea5",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 138,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "78b690f2_96b1fcde",
|
||||
"range": {
|
||||
"startLine": 138,
|
||||
"startChar": 0,
|
||||
"endLine": 138,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -227,6 +299,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d13f738b_460f1273",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 157,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "I separated the cases that match the old (offline/non-FS) behavior from the ones for the new online FS behavior to try and differentiate it better.",
|
||||
"parentUuid": "fe42a4d4_4a421825",
|
||||
"range": {
|
||||
"startLine": 157,
|
||||
"startChar": 2,
|
||||
"endLine": 157,
|
||||
"endChar": 45
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -274,6 +370,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2db34200_215c3b7b",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 182,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "I tried tried to reword that paragraph to make that more clear.",
|
||||
"parentUuid": "8d3fe825_7505155e",
|
||||
"range": {
|
||||
"startLine": 179,
|
||||
"startChar": 63,
|
||||
"endLine": 182,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -321,6 +441,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "006c4812_9cfb22ed",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 191,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "I added that reasoning to the section.",
|
||||
"parentUuid": "8123b808_bd1ed809",
|
||||
"range": {
|
||||
"startLine": 190,
|
||||
"startChar": 8,
|
||||
"endLine": 191,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -368,6 +512,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "576a9279_b7638b7b",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 235,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "I have changed the section so that both keys are now removed from the admin metadata by os-reset_status.",
|
||||
"parentUuid": "491ae103_6ee40f04",
|
||||
"range": {
|
||||
"startLine": 235,
|
||||
"startChar": 26,
|
||||
"endLine": 235,
|
||||
"endChar": 49
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -414,6 +582,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "9fd198c2_eb236970",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 392,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "6bf3773c_13b3d426",
|
||||
"range": {
|
||||
"startLine": 392,
|
||||
"startChar": 2,
|
||||
"endLine": 392,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -430,6 +622,24 @@
|
|||
"message": "We also need tempest integration test for the whole operation and interaction between nova and cinder",
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f9ff9f89_4ff50757",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 409,
|
||||
"author": {
|
||||
"id": 34859
|
||||
},
|
||||
"writtenOn": "2022-12-22T13:33:58Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5c2fe19d_1819435b",
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue